From: "David S. Miller" <davem@davemloft.net>
To: Robin Holt <holt@sgi.com>
Cc: holt@sgi.com, akpm@osdl.org, yoshfuji@linux-ipv6.org,
hirofumi@parknet.co.jp, torvalds@osdl.org, dipankar@ibm.com,
laforge@gnumonks.org, bunk@stusta.de, herbert@apana.org.au,
paulmck@ibm.com, netdev@oss.sgi.com,
linux-kernel@vger.kernel.org, gnb@sgi.com
Subject: Re: [RFC] Limit the size of the IPV4 route hash.
Date: Sun, 12 Dec 2004 16:55:46 -0800 [thread overview]
Message-ID: <20041212165546.1808536e.davem@davemloft.net> (raw)
In-Reply-To: <20041210234037.GB25582@lnx-holt.americas.sgi.com>
On Fri, 10 Dec 2004 17:40:37 -0600
Robin Holt <holt@sgi.com> wrote:
> Sorry, I was asleep at the wheel. I failed to even grok your second
> paragraph. I will fall back to agreeing with the printk to let the admin
> know that something is amiss.
>
> Should we possibly modify the output of /proc/net/rt_cache (or whatever
> its name is) to include the hash bucket so people can watch to see how
> many bucket collisions their system has?
I think there are rt stats for this already added by Robert Olsson.
One thing not mentioned, besides the physically contiguous issue,
is that fact that the locking would need to be changed quite a bit
in order to allow runtime reallocation of the hash table. The current
code is certainly not ready for it. It might just work to run the
hash freeing via RCU, but I'm not quite sure.
prev parent reply other threads:[~2004-12-13 0:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-10 19:00 [RFC] Limit the size of the IPV4 route hash Robin Holt
2004-12-10 19:48 ` David S. Miller
2004-12-10 21:00 ` Robin Holt
2004-12-10 21:06 ` David S. Miller
2004-12-10 21:09 ` Andrew Morton
2004-12-10 23:27 ` Robin Holt
2004-12-10 23:38 ` Andrew Morton
2004-12-10 23:37 ` Robin Holt
2004-12-10 23:40 ` Robin Holt
2004-12-13 0:55 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041212165546.1808536e.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=dipankar@ibm.com \
--cc=gnb@sgi.com \
--cc=herbert@apana.org.au \
--cc=hirofumi@parknet.co.jp \
--cc=holt@sgi.com \
--cc=laforge@gnumonks.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=paulmck@ibm.com \
--cc=torvalds@osdl.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).