From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Graf Subject: Re: request_module while holding rtnl semaphore Date: Sun, 12 Dec 2004 18:57:36 +0100 Message-ID: <20041212175736.GA8493@postel.suug.ch> References: <41899DCF.3050804@trash.net> <20041109161126.376f755c.davem@davemloft.net> <20041110010113.GJ31969@postel.suug.ch> <41916A91.3080107@trash.net> <20041110012251.GK31969@postel.suug.ch> <41916F0B.5010809@trash.net> <20041110013941.GL31969@postel.suug.ch> <41917330.6090002@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , Herbert Xu , netdev@oss.sgi.com Return-path: To: Patrick McHardy Content-Disposition: inline In-Reply-To: <41917330.6090002@trash.net> Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org > >>Assuming all error-paths do proper cleanup, returning -EAGAIN > >>should always result in the same configuration state as before. > >I agree but this assumption is wrong, at least for u32. > > > It will be true soon :) Anything else is a bug, and a nice > side-effect of this change is that all those dusty error-paths > actually get used. I started working on a patchset to clean up all the error paths, allow changing all pararmeters for those not supporting it yet and to add the action bits for tcindex, route, and rsvp. Finishing it and writing all the test cases to do proper testing will take some time but I hope to have it ready for early 2.6.11 inclusion. Just to let you know so we don't do redundant work.