From: Adrian Bunk <bunk@stusta.de>
To: acme@conectiva.com.br
Cc: netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: [2.6 patch] net/appletalk/: make some code static
Date: Sun, 12 Dec 2004 22:11:28 +0100 [thread overview]
Message-ID: <20041212211128.GW22324@stusta.de> (raw)
The patch below makes some needlessly global code static.
diffstat output:
include/linux/atalk.h | 2 --
net/appletalk/aarp.c | 4 ++--
net/appletalk/atalk_proc.c | 6 +++---
net/appletalk/ddp.c | 6 +++---
4 files changed, 8 insertions(+), 10 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc2-mm4-full/include/linux/atalk.h.old 2004-12-12 18:21:46.000000000 +0100
+++ linux-2.6.10-rc2-mm4-full/include/linux/atalk.h 2004-12-12 18:21:53.000000000 +0100
@@ -188,8 +188,6 @@
extern int aarp_send_ddp(struct net_device *dev,
struct sk_buff *skb,
struct atalk_addr *sa, void *hwaddr);
-extern void aarp_send_probe(struct net_device *dev,
- struct atalk_addr *addr);
extern void aarp_device_down(struct net_device *dev);
extern void aarp_probe_network(struct atalk_iface *atif);
extern int aarp_proxy_probe_network(struct atalk_iface *atif,
--- linux-2.6.10-rc2-mm4-full/net/appletalk/aarp.c.old 2004-12-12 18:22:02.000000000 +0100
+++ linux-2.6.10-rc2-mm4-full/net/appletalk/aarp.c 2004-12-12 18:22:12.000000000 +0100
@@ -199,7 +199,7 @@
* aarp_proxy_probe_network.
*/
-void aarp_send_probe(struct net_device *dev, struct atalk_addr *us)
+static void aarp_send_probe(struct net_device *dev, struct atalk_addr *us)
{
struct elapaarp *eah;
int len = dev->hard_header_len + sizeof(*eah) + aarp_dl->header_length;
@@ -429,7 +429,7 @@
* Probe a Phase 1 device or a device that requires its Net:Node to
* be set via an ioctl.
*/
-void aarp_send_probe_phase1(struct atalk_iface *iface)
+static void aarp_send_probe_phase1(struct atalk_iface *iface)
{
struct ifreq atreq;
struct sockaddr_at *sa = (struct sockaddr_at *)&atreq.ifr_addr;
--- linux-2.6.10-rc2-mm4-full/net/appletalk/atalk_proc.c.old 2004-12-12 18:22:28.000000000 +0100
+++ linux-2.6.10-rc2-mm4-full/net/appletalk/atalk_proc.c 2004-12-12 18:23:02.000000000 +0100
@@ -205,21 +205,21 @@
return 0;
}
-struct seq_operations atalk_seq_interface_ops = {
+static struct seq_operations atalk_seq_interface_ops = {
.start = atalk_seq_interface_start,
.next = atalk_seq_interface_next,
.stop = atalk_seq_interface_stop,
.show = atalk_seq_interface_show,
};
-struct seq_operations atalk_seq_route_ops = {
+static struct seq_operations atalk_seq_route_ops = {
.start = atalk_seq_route_start,
.next = atalk_seq_route_next,
.stop = atalk_seq_route_stop,
.show = atalk_seq_route_show,
};
-struct seq_operations atalk_seq_socket_ops = {
+static struct seq_operations atalk_seq_socket_ops = {
.start = atalk_seq_socket_start,
.next = atalk_seq_socket_next,
.stop = atalk_seq_socket_stop,
--- linux-2.6.10-rc2-mm4-full/net/appletalk/ddp.c.old 2004-12-12 18:23:35.000000000 +0100
+++ linux-2.6.10-rc2-mm4-full/net/appletalk/ddp.c 2004-12-12 18:24:11.000000000 +0100
@@ -612,7 +612,7 @@
* Called when a device is downed. Just throw away any routes
* via it.
*/
-void atrtr_device_down(struct net_device *dev)
+static void atrtr_device_down(struct net_device *dev)
{
struct atalk_route **r = &atalk_routes;
struct atalk_route *tmp;
@@ -1854,12 +1854,12 @@
.notifier_call = ddp_device_event,
};
-struct packet_type ltalk_packet_type = {
+static struct packet_type ltalk_packet_type = {
.type = __constant_htons(ETH_P_LOCALTALK),
.func = ltalk_rcv,
};
-struct packet_type ppptalk_packet_type = {
+static struct packet_type ppptalk_packet_type = {
.type = __constant_htons(ETH_P_PPPTALK),
.func = atalk_rcv,
};
next reply other threads:[~2004-12-12 21:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-12 21:11 Adrian Bunk [this message]
2004-12-28 2:50 ` [2.6 patch] net/appletalk/: make some code static David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041212211128.GW22324@stusta.de \
--to=bunk@stusta.de \
--cc=acme@conectiva.com.br \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).