netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: Patrick McHardy <kaber@trash.net>
Cc: shemminger@osdl.org, netem@osdl.org, netdev@oss.sgi.com
Subject: Re: [PATCH] netem: restart device after inserting packets
Date: Tue, 14 Dec 2004 11:32:49 -0800	[thread overview]
Message-ID: <20041214113249.0725a655.davem@davemloft.net> (raw)
In-Reply-To: <41B91901.3070304@trash.net>

On Fri, 10 Dec 2004 04:33:21 +0100
Patrick McHardy <kaber@trash.net> wrote:

> The patch is incomplete, netem may dequeue multiple packets from
> the delayed queue at once and feed them to the inner queue, but
> qdisc_restart will only dequeue one packet from the inner queue.
> This patch moves qdisc_run back to include/net/pkt_sched.h and
> replaces qdisc_restart by qdisc_run in netem_watchdog.

Applied, thanks Patrick.

Don't we need 2.4.x versions of these two fixes?

  parent reply	other threads:[~2004-12-14 19:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-08 20:31 [PATCH] netem: restart device after inserting packets Stephen Hemminger
2004-12-09  5:00 ` David S. Miller
2004-12-10  3:33   ` Patrick McHardy
2004-12-13 19:08     ` Stephen Hemminger
2004-12-14 19:32     ` David S. Miller [this message]
2004-12-14 21:11       ` Stephen Hemminger
2004-12-20 23:43         ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041214113249.0725a655.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=netdev@oss.sgi.com \
    --cc=netem@osdl.org \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).