From mboxrd@z Thu Jan 1 00:00:00 1970 From: "David S. Miller" Subject: Re: [PATCH] netem: restart device after inserting packets Date: Tue, 14 Dec 2004 11:32:49 -0800 Message-ID: <20041214113249.0725a655.davem@davemloft.net> References: <20041208123103.4cc6b005@dxpl.pdx.osdl.net> <20041208210031.63f0963f.davem@davemloft.net> <41B91901.3070304@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: shemminger@osdl.org, netem@osdl.org, netdev@oss.sgi.com Return-path: To: Patrick McHardy In-Reply-To: <41B91901.3070304@trash.net> Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org On Fri, 10 Dec 2004 04:33:21 +0100 Patrick McHardy wrote: > The patch is incomplete, netem may dequeue multiple packets from > the delayed queue at once and feed them to the inner queue, but > qdisc_restart will only dequeue one packet from the inner queue. > This patch moves qdisc_run back to include/net/pkt_sched.h and > replaces qdisc_restart by qdisc_run in netem_watchdog. Applied, thanks Patrick. Don't we need 2.4.x versions of these two fixes?