Re: [2.6 patch] net/decnet/: misc possible cleanups

[Steven Whitehouse <steve@chygwyn.com>]

Hi,

In general this looks fine to me. Patrick has the last word though. I
would suggest hanging on to the fast timer code though for now... its
there so that delayed acks can be used and the rest of the code is
very close to actually allowing that to work. The DECnet code has a
habit of sending lots of (rather small) ack packets and it would be nice if
that could be fixed at some stage.

The issues at stake are that it would interact with the code thats working
out what the correct send window is to a certain extent. I know there is
also the argument that it can always be added back should someone have time
to add delayed acks, so I've no strong opinion either way.

Also, when I was writing the routing code - a lot of the design was "borrowed"
from the ipv4 routing code. It might be worth doing a comparison to see where
the two have diverged (something I used to do now and again) to pick up any
bugs I'd inadvertently copied over, if you are working on clean ups in this
area,

Steve.

On Tue, Dec 14, 2004 at 01:58:38PM +0100, Adrian Bunk wrote:
> The patch below contains the following possible cleanups:
> - make needlessly global code static
> - dn_fib.c: remove the write-only global variable dn_fib_info_cnt
> - dn_fib.c: remove the unused global function dn_fib_rt_message
> - dn_neigh.c: remove the unused global function dn_neigh_pointopoint_notify
> - dn_timer.c: remove the fast timer code that isn't used
> 
> Please review and comment on this patch.