From: "David S. Miller" <davem@davemloft.net>
To: Peter Chubb <peterc@gelato.unsw.edu.au>
Cc: netdev@oss.sgi.com
Subject: Re: TG3 fix for slow switches (Was: TG3 driver failure on HP 16-way)
Date: Mon, 20 Dec 2004 16:15:52 -0800 [thread overview]
Message-ID: <20041220161552.2b88aa3d.davem@davemloft.net> (raw)
In-Reply-To: <16839.27239.264551.415058@berry.gelato.unsw.EDU.AU>
On Tue, 21 Dec 2004 11:12:23 +1100
Peter Chubb <peterc@gelato.unsw.edu.au> wrote:
> The problem is that the driver gives up before the switch that the NIC
> is connected to has finished the negotiation phase.
>
> Here's a simple patch. I changed the way the loop works too, because
> tg3_readphys() sets *val to 0xffffffff if it fails.
This patch shouldn't be needed. This waiting loop is just an
optimization in case we can negotiation quickly.
If the loop fails, we just wait for the chip to interrupt us
when the link status changes next (or we notice a link status
change via timer based polling which we use on chips which can't
provide the interrupt based notification properly), at which
time we'll call tg3_setup_copper_phy() from the interrupt handler.
You need to figure out why that isn't working correctly.
next prev parent reply other threads:[~2004-12-21 0:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-21 0:12 TG3 fix for slow switches (Was: TG3 driver failure on HP 16-way) Peter Chubb
2004-12-21 0:15 ` David S. Miller [this message]
2004-12-21 1:11 ` Peter Chubb
2004-12-21 6:19 ` David S. Miller
2005-01-06 23:19 ` David S. Miller
2005-01-07 0:17 ` Darren Williams
2005-01-07 3:48 ` David S. Miller
2005-01-07 5:30 ` Darren Williams
2005-01-07 5:28 ` David S. Miller
2005-01-07 9:25 ` Darren Williams
-- strict thread matches above, loose matches on Subject: below --
2004-12-23 0:02 Michael Chan
2004-12-23 4:31 ` David S. Miller
2005-05-31 15:38 ` Grant Grundler
2005-05-31 17:22 ` Michael Chan
2005-05-31 18:36 ` Grant Grundler
2005-05-31 17:42 ` Michael Chan
2005-05-31 19:03 ` Grant Grundler
2005-05-31 18:22 ` Michael Chan
2004-12-23 8:14 Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041220161552.2b88aa3d.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
--cc=peterc@gelato.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).