From: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: Adrian Bunk <bunk-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org>
Cc: irda-users-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
netdev-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [2.6 patch] net/irda/: misc possible cleanups
Date: Mon, 27 Dec 2004 21:12:43 -0800 [thread overview]
Message-ID: <20041227211243.7d05e891.davem@davemloft.net> (raw)
In-Reply-To: <20041215010528.GA12937-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org>
On Wed, 15 Dec 2004 02:05:28 +0100
Adrian Bunk <bunk-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org> wrote:
> The patch below contains the following possible cleanups:
> - make some needlessly global code static
> - remove the following unused global functions:
> - discovery.c: irlmp_find_device
> - ircomm/ircomm_param.c: ircomm_param_flush
> - irda_device.c: irda_device_set_dtr_rts
> - irda_device.c: irda_device_change_speed
> - irda_device.c: irda_device_set_mode
> - iriap.c: iriap_getinfobasedetails_request
> - iriap.c: iriap_getinfobasedetails_confirm
> - iriap.c: iriap_getobjects_request
> - iriap.c: iriap_getobjects_confirm
> - iriap.c: iriap_getvalue
> - irlan_client.c: irlan_client_reconnect_data_channel
> - irlap_frame.c: irlap_send_frmr_frame
> - irlmp.c: irlmp_status_request
> - remove the follwong unused global variables:
> - irnet/irnet_ppp.c: irnet_ppp_ops
> - irsysctl.c: sysctl_compression
> - qos.c: #ifndef CONFIG_IRDA_DYNAMIC_WINDOW irlap_requested_line_capacity
Looks good, applied. Thanks Adrian.
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
prev parent reply other threads:[~2004-12-28 5:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-15 1:05 [2.6 patch] net/irda/: misc possible cleanups Adrian Bunk
[not found] ` <20041215010528.GA12937-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org>
2004-12-28 5:12 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041227211243.7d05e891.davem@davemloft.net \
--to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
--cc=bunk-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org \
--cc=irda-users-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).