netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Herbert Poetzl <herbert@13thfloor.at>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: "Arnaldo Carvalho de Melo" <acme@conectiva.com.br>,
	"Jörn Engel" <joern@wohnheim.fh-wedel.de>,
	"Networking Team" <netdev@oss.sgi.com>,
	linux-net <linux-net@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Alexey Kuznetsov" <kuznet@ms2.inr.ac.ru>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Patch: add loglevel to printk's in net/ipv4/route.c
Date: Thu, 30 Dec 2004 03:12:39 +0100	[thread overview]
Message-ID: <20041230021239.GA31474@mail.13thfloor.at> (raw)
In-Reply-To: <Pine.LNX.4.61.0412300037310.3495@dragon.hygekrogen.localhost>

On Thu, Dec 30, 2004 at 12:39:10AM +0100, Jesper Juhl wrote:
> On Wed, 29 Dec 2004, Jesper Juhl wrote:
> 
> > On Wed, 29 Dec 2004, Arnaldo Carvalho de Melo wrote:
> > 
> > > 
> > > 
> > > Jörn Engel wrote:
> > > > On Wed, 29 December 2004 00:10:22 -0200, Arnaldo Carvalho de Melo wrote:
> > > > 
> > > > > > It doesn't make much difference, it's mostly for
> > > > > > completeness/correctness.
> > > > > 
> > > > > No, it does a helluva difference, give it a try :-)
> > > > 
> > > > 
> > > > hint: look for "\n"
> > > 
> > > hint2: Or the _lack_ of "\n" 8)
> > > 
> > 
> > Ok, obviously something's wrong, but it's currently 03:44 here, so I'll 
> > take a look at it tomorrow (or quite possibly the day after since I have 
> > things to do).
> > Thank you for commenting, I'll dig into it at the first oppotunity I have.
> > 
> > 
> Ok, this is a bit embarresing. Looking at the patch now after getting some 
> sleep it's quite obvious that it is wrong. I should have slept on it 
> before sending it - sorry for the noise people.

nothing to be sorry about, and thanks for all
the work you are doing for the linux kernel ...

best,
Herbert

> -- 
> Jesper Juhl
> 
> 
> 
> 

      reply	other threads:[~2004-12-30  2:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-29  2:01 Patch: add loglevel to printk's in net/ipv4/route.c Jesper Juhl
2004-12-29  2:02 ` Arnaldo Carvalho de Melo
2004-12-29  2:13   ` Jesper Juhl
2004-12-29  2:10     ` Arnaldo Carvalho de Melo
2004-12-29  2:12       ` Jörn Engel
2004-12-29  2:23         ` Arnaldo Carvalho de Melo
2004-12-29  2:46           ` Jesper Juhl
2004-12-29 23:39             ` Jesper Juhl
2004-12-30  2:12               ` Herbert Poetzl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041230021239.GA31474@mail.13thfloor.at \
    --to=herbert@13thfloor.at \
    --cc=acme@conectiva.com.br \
    --cc=davem@davemloft.net \
    --cc=joern@wohnheim.fh-wedel.de \
    --cc=juhl-lkml@dif.dk \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).