From: David Dillow <dave@thedillows.org>
To: netdev@oss.sgi.com
Cc: linux-kernel@vger.kernel.org, dave@thedillows.org
Subject: [RFC 2.6.10 11/22] AH, ESP: Add offloading of inbound packets
Date: Thu, 30 Dec 2004 03:48:36 -0500 [thread overview]
Message-ID: <20041230035000.20@ori.thedillows.org> (raw)
In-Reply-To: 20041230035000.19@ori.thedillows.org
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/12/30 00:47:54-05:00 dave@thedillows.org
# Add crypto offload for inbound IPv4 AH xfrms.
#
# Signed-off-by: David Dillow <dave@thedillows.org>
#
# net/ipv4/esp4.c
# 2004/12/30 00:47:36-05:00 dave@thedillows.org +30 -16
# Add crypto offload for inbound IPv4 AH xfrms.
#
# Signed-off-by: David Dillow <dave@thedillows.org>
#
# net/ipv4/ah4.c
# 2004/12/30 00:47:36-05:00 dave@thedillows.org +13 -4
# Add crypto offload for inbound IPv4 AH xfrms.
#
# Signed-off-by: David Dillow <dave@thedillows.org>
#
diff -Nru a/net/ipv4/ah4.c b/net/ipv4/ah4.c
--- a/net/ipv4/ah4.c 2004-12-30 01:10:02 -05:00
+++ b/net/ipv4/ah4.c 2004-12-30 01:10:02 -05:00
@@ -138,6 +138,7 @@
struct iphdr *iph;
struct ip_auth_hdr *ah;
struct ah_data *ahp;
+ int offload;
char work_buf[60];
if (!pskb_may_pull(skb, sizeof(struct ip_auth_hdr)))
@@ -164,6 +165,7 @@
ah = (struct ip_auth_hdr*)skb->data;
iph = skb->nh.iph;
+ offload = skb_pop_xfrm_result(skb);
memcpy(work_buf, iph, iph->ihl*4);
@@ -181,10 +183,17 @@
memcpy(auth_data, ah->auth_data, ahp->icv_trunc_len);
skb_push(skb, skb->data - skb->nh.raw);
- ahp->icv(ahp, skb, ah->auth_data);
- if (memcmp(ah->auth_data, auth_data, ahp->icv_trunc_len)) {
- x->stats.integrity_failed++;
- goto out;
+ if (offload & XFRM_OFFLOAD_AUTH) {
+ if (unlikely(offload & XFRM_OFFLOAD_AUTH_FAIL)) {
+ x->stats.integrity_failed++;
+ goto out;
+ }
+ } else {
+ ahp->icv(ahp, skb, ah->auth_data);
+ if (memcmp(ah->auth_data, auth_data, ahp->icv_trunc_len)) {
+ x->stats.integrity_failed++;
+ goto out;
+ }
}
}
((struct iphdr*)work_buf)->protocol = ah->nexthdr;
diff -Nru a/net/ipv4/esp4.c b/net/ipv4/esp4.c
--- a/net/ipv4/esp4.c 2004-12-30 01:10:02 -05:00
+++ b/net/ipv4/esp4.c 2004-12-30 01:10:02 -05:00
@@ -164,6 +164,7 @@
int elen = skb->len - sizeof(struct ip_esp_hdr) - esp->conf.ivlen - alen;
int nfrags;
int encap_len = 0;
+ int offload;
if (!pskb_may_pull(skb, sizeof(struct ip_esp_hdr)))
goto out;
@@ -171,22 +172,32 @@
if (elen <= 0 || (elen & (blksize-1)))
goto out;
+ offload = skb_pop_xfrm_result(skb);
+
/* If integrity check is required, do this. */
if (esp->auth.icv_full_len) {
- u8 sum[esp->auth.icv_full_len];
- u8 sum1[alen];
+ if (unlikely(offload & XFRM_OFFLOAD_AUTH_FAIL)) {
+ x->stats.integrity_failed++;
+ goto out;
+ }
+
+ if (!(offload & XFRM_OFFLOAD_AUTH)) {
+ u8 sum[esp->auth.icv_full_len];
+ u8 sum1[alen];
- esp->auth.icv(esp, skb, 0, skb->len-alen, sum);
+ esp->auth.icv(esp, skb, 0, skb->len-alen, sum);
- if (skb_copy_bits(skb, skb->len-alen, sum1, alen))
- BUG();
+ if (skb_copy_bits(skb, skb->len-alen, sum1, alen))
+ BUG();
- if (unlikely(memcmp(sum, sum1, alen))) {
- x->stats.integrity_failed++;
- goto out;
+ if (unlikely(memcmp(sum, sum1, alen))) {
+ x->stats.integrity_failed++;
+ goto out;
+ }
}
}
+ /* XXX I think this can be moved to the !offload case */
if ((nfrags = skb_cow_data(skb, 0, &trailer)) < 0)
goto out;
@@ -195,15 +206,12 @@
esph = (struct ip_esp_hdr*)skb->data;
iph = skb->nh.iph;
- /* Get ivec. This can be wrong, check against another impls. */
- if (esp->conf.ivlen)
- crypto_cipher_set_iv(esp->conf.tfm, esph->enc_data, crypto_tfm_alg_ivsize(esp->conf.tfm));
-
- {
- u8 nexthdr[2];
+ if (!(offload & XFRM_OFFLOAD_CONF)) {
struct scatterlist *sg = &esp->sgbuf[0];
- u8 workbuf[60];
- int padlen;
+
+ /* Get ivec. This can be wrong, check against another impls. */
+ if (esp->conf.ivlen)
+ crypto_cipher_set_iv(esp->conf.tfm, esph->enc_data, crypto_tfm_alg_ivsize(esp->conf.tfm));
if (unlikely(nfrags > ESP_NUM_FAST_SG)) {
sg = kmalloc(sizeof(struct scatterlist)*nfrags, GFP_ATOMIC);
@@ -214,6 +222,12 @@
crypto_cipher_decrypt(esp->conf.tfm, sg, sg, elen);
if (unlikely(sg != &esp->sgbuf[0]))
kfree(sg);
+ }
+
+ {
+ u8 nexthdr[2];
+ u8 workbuf[60];
+ int padlen;
if (skb_copy_bits(skb, skb->len-alen-2, nexthdr, 2))
BUG();
next prev parent reply other threads:[~2004-12-30 8:48 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-30 8:48 [RFC 2.6.10 0/22] Add hardware assist for IPSEC crypto David Dillow
2004-12-30 8:48 ` [RFC 2.6.10 1/22] xfrm: Add direction information to xfrm_state David Dillow
2004-12-30 8:48 ` [RFC 2.6.10 2/22] xfrm: Add xfrm offload management calls to struct netdevice David Dillow
2004-12-30 8:48 ` [RFC 2.6.10 3/22] xfrm: Add offload management routines David Dillow
2004-12-30 8:48 ` [RFC 2.6.10 4/22] xfrm: Try to offload inbound xfrm_states David Dillow
2004-12-30 8:48 ` [RFC 2.6.10 5/22] xfrm: Attempt to offload bundled xfrm_states for outbound xfrms David Dillow
2004-12-30 8:48 ` [RFC 2.6.10 6/22] xfrm: add a parameter to xfrm_prune_bundles() David Dillow
2004-12-30 8:48 ` [RFC 2.6.10 7/22] xfrm: Allow device drivers to force recalculation of offloads David Dillow
2004-12-30 8:48 ` [RFC 2.6.10 8/22] skbuff: Add routines to manage applied offloads per skb David Dillow
2004-12-30 8:48 ` [RFC 2.6.10 9/22] AH: Split header initialization from zeroing of mutable fields David Dillow
2004-12-30 8:48 ` [RFC 2.6.10 10/22] AH, ESP: Add offloading of outbound packets David Dillow
2004-12-30 8:48 ` David Dillow [this message]
2004-12-30 8:48 ` [RFC 2.6.10 12/22] ethtool: Add support for crypto offload David Dillow
2004-12-30 8:48 ` [RFC 2.6.10 13/22] typhoon: Make the ipsec descriptor match actual usage David Dillow
2004-12-30 8:48 ` [RFC 2.6.10 14/22] typhoon: add inbound offload result processing David Dillow
2004-12-30 8:48 ` [RFC 2.6.10 15/22] typhoon: add outbound offload processing David Dillow
2004-12-30 8:48 ` [RFC 2.6.10 16/22] typhoon: collect crypto offload capabilities David Dillow
2004-12-30 8:48 ` [RFC 2.6.10 17/22] typhoon: split out setting of offloaded tasks David Dillow
2004-12-30 8:48 ` [RFC 2.6.10 18/22] typhoon: add validation of offloaded xfrm_states David Dillow
2004-12-30 8:48 ` [RFC 2.6.10 19/22] typhoon: add loading of xfrm_states to hardware David Dillow
2004-12-30 8:48 ` [RFC 2.6.10 20/22] typhoon: add management of outbound bundles David Dillow
2004-12-30 8:48 ` [RFC 2.6.10 21/22] typhoon: add callbacks to support crypto offload David Dillow
2004-12-30 8:48 ` [RFC 2.6.10 22/22] Add some documentation for the IPSEC " David Dillow
2005-01-21 23:23 ` [RFC 2.6.10 7/22] xfrm: Allow device drivers to force recalculation of offloads David S. Miller
2005-01-22 5:53 ` David Dillow
2005-01-26 6:11 ` David S. Miller
2005-01-21 23:21 ` [RFC 2.6.10 6/22] xfrm: add a parameter to xfrm_prune_bundles() David S. Miller
2004-12-30 23:34 ` [RFC 2.6.10 5/22] xfrm: Attempt to offload bundled xfrm_states for outbound xfrms Francois Romieu
2004-12-31 3:31 ` David Dillow
2005-01-21 23:20 ` David S. Miller
2005-01-22 5:53 ` David Dillow
2005-01-26 6:11 ` David S. Miller
2005-01-21 22:56 ` [RFC 2.6.10 4/22] xfrm: Try to offload inbound xfrm_states David S. Miller
2005-01-22 5:52 ` David Dillow
2005-01-26 6:13 ` David S. Miller
2005-01-21 22:47 ` [RFC 2.6.10 3/22] xfrm: Add offload management routines David S. Miller
2005-01-22 6:00 ` David Dillow
[not found] ` <1106373038.3691.39.camel@ori.thedillows.org>
[not found] ` <20050125221608.0cb067b2.davem@davemloft.net>
2005-01-26 21:30 ` David Dillow
2005-01-21 22:40 ` [RFC 2.6.10 2/22] xfrm: Add xfrm offload management calls to struct netdevice David S. Miller
2004-12-30 9:48 ` [RFC 2.6.10 1/22] xfrm: Add direction information to xfrm_state Jan-Benedict Glaw
2004-12-30 16:16 ` Dave Dillow
2004-12-30 16:36 ` Jan-Benedict Glaw
[not found] ` <200412301436.06653.ioe-lkml@axxeo.de>
2004-12-30 16:21 ` Dave Dillow
2005-01-21 22:38 ` David S. Miller
2005-01-22 5:50 ` David Dillow
2005-01-26 6:17 ` David S. Miller
2005-01-26 21:14 ` David Dillow
2005-01-21 22:35 ` [RFC 2.6.10 0/22] Add hardware assist for IPSEC crypto David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041230035000.20@ori.thedillows.org \
--to=dave@thedillows.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).