From: "David S. Miller" <davem@davemloft.net>
To: Peter Chubb <peterc@gelato.unsw.edu.au>
Cc: peterc@gelato.unsw.edu.au, netdev@oss.sgi.com
Subject: Re: TG3 fix for slow switches (Was: TG3 driver failure on HP 16-way)
Date: Thu, 6 Jan 2005 15:19:10 -0800 [thread overview]
Message-ID: <20050106151910.4d51673e.davem@davemloft.net> (raw)
In-Reply-To: <16839.30796.413939.333935@wombat.chubb.wattle.id.au>
Peter, let me know if this patch solves your PHY link up problem
too.
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2005/01/06 14:53:55-08:00 davem@nuts.davemloft.net
# [TG3]: Return 0 when PHY read times out, not all-ones.
#
# Noticed by Peter Chubb.
#
# Signed-off-by: David S. Miller <davem@davemloft.net>
#
# drivers/net/tg3.c
# 2005/01/06 14:53:07-08:00 davem@nuts.davemloft.net +1 -1
# [TG3]: Return 0 when PHY read times out, not all-ones.
#
diff -Nru a/drivers/net/tg3.c b/drivers/net/tg3.c
--- a/drivers/net/tg3.c 2005-01-06 14:54:21 -08:00
+++ b/drivers/net/tg3.c 2005-01-06 14:54:21 -08:00
@@ -485,7 +485,7 @@
udelay(80);
}
- *val = 0xffffffff;
+ *val = 0x0;
frame_val = ((PHY_ADDR << MI_COM_PHY_ADDR_SHIFT) &
MI_COM_PHY_ADDR_MASK);
next prev parent reply other threads:[~2005-01-06 23:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-21 0:12 TG3 fix for slow switches (Was: TG3 driver failure on HP 16-way) Peter Chubb
2004-12-21 0:15 ` David S. Miller
2004-12-21 1:11 ` Peter Chubb
2004-12-21 6:19 ` David S. Miller
2005-01-06 23:19 ` David S. Miller [this message]
2005-01-07 0:17 ` Darren Williams
2005-01-07 3:48 ` David S. Miller
2005-01-07 5:30 ` Darren Williams
2005-01-07 5:28 ` David S. Miller
2005-01-07 9:25 ` Darren Williams
-- strict thread matches above, loose matches on Subject: below --
2004-12-23 0:02 Michael Chan
2004-12-23 4:31 ` David S. Miller
2005-05-31 15:38 ` Grant Grundler
2005-05-31 17:22 ` Michael Chan
2005-05-31 18:36 ` Grant Grundler
2005-05-31 17:42 ` Michael Chan
2005-05-31 19:03 ` Grant Grundler
2005-05-31 18:22 ` Michael Chan
2004-12-23 8:14 Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050106151910.4d51673e.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
--cc=peterc@gelato.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).