From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Aravamudan Subject: [KJ] [PATCH 6/28] net/e1000_osdep: replace schedule_timeout() with msleep() Date: Thu, 6 Jan 2005 16:19:31 -0800 Message-ID: <20050107001931.GH3055@us.ibm.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============11017806919943185==" Cc: linux-net@vger.kernel.org, kernel-janitors@lists.osdl.org, netdev@oss.sgi.com Return-path: To: cramerj@intel.com, john.ronciak@intel.com, ganesh.venkatesan@intel.com List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kernel-janitors-bounces@lists.osdl.org Errors-To: kernel-janitors-bounces@lists.osdl.org List-Id: netdev.vger.kernel.org --===============11017806919943185== Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, Description: Use msleep() instead of schedule_timeout() to guarantee the task delays as expected. Signed-off-by: Nishanth Aravamudan --- 2.6.10-v/drivers/net/e1000/e1000_osdep.h 2004-12-24 13:34:26.000000000 -0800 +++ 2.6.10/drivers/net/e1000/e1000_osdep.h 2005-01-04 14:57:49.000000000 -0800 @@ -46,8 +46,7 @@ /* Don't mdelay in interrupt context! */ \ BUG(); \ } else { \ - set_current_state(TASK_UNINTERRUPTIBLE); \ - schedule_timeout((x * HZ)/1000 + 2); \ + msleep(x); } } while(0) /* Some workarounds require millisecond delays and are run during interrupt * context. Most notably, when establishing link, the phy may need tweaking --===============11017806919943185== Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org http://lists.osdl.org/mailman/listinfo/kernel-janitors --===============11017806919943185==--