From: Christoph Hellwig <hch@lst.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: jgarzik@pobox.com, netdev@oss.sgi.com
Subject: Re: [PATCH 2/2] use rtnl_lock_interruptible in 8139 to avoid shutdown hang
Date: Mon, 10 Jan 2005 22:45:22 +0100 [thread overview]
Message-ID: <20050110214522.GA17463@lst.de> (raw)
In-Reply-To: <20050110133714.023aa21b.davem@davemloft.net>
On Mon, Jan 10, 2005 at 01:37:14PM -0800, David S. Miller wrote:
> On Sun, 9 Jan 2005 13:16:30 +0100
> Christoph Hellwig <hch@lst.de> wrote:
>
> > The 8139too thread needs to use rtnl_lock_interruptible so it can avoid
> > doing the actual work once it's been kill_proc()ed on module removal
> > time.
> >
> > Based on debugging and an earlier patch that adds a driver-private
> > semaphore from Herbert Xu.
>
> I've applied these two patches, they look perfectly fine.
> Thanks Christoph.
Btw, there's some confusing between rtnl_lock and rtnl_shlock (similar
for the other variants). Is there an agenda behind this versions or
would you take a patch that unifies the lock assecors?
next prev parent reply other threads:[~2005-01-10 21:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-09 12:16 [PATCH 2/2] use rtnl_lock_interruptible in 8139 to avoid shutdown hang Christoph Hellwig
2005-01-10 21:37 ` David S. Miller
2005-01-10 21:45 ` Christoph Hellwig [this message]
2005-01-11 1:50 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050110214522.GA17463@lst.de \
--to=hch@lst.de \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).