* [PATCH 2/2] use rtnl_lock_interruptible in 8139 to avoid shutdown hang
@ 2005-01-09 12:16 Christoph Hellwig
2005-01-10 21:37 ` David S. Miller
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2005-01-09 12:16 UTC (permalink / raw)
To: davem, jgarzik; +Cc: netdev
The 8139too thread needs to use rtnl_lock_interruptible so it can avoid
doing the actual work once it's been kill_proc()ed on module removal
time.
Based on debugging and an earlier patch that adds a driver-private
semaphore from Herbert Xu.
--- 1.101/drivers/net/8139too.c 2004-10-30 02:00:00 +02:00
+++ edited/drivers/net/8139too.c 2005-01-09 12:55:31 +01:00
@@ -1636,7 +1636,8 @@
if (tp->time_to_die)
break;
- rtnl_lock ();
+ if (rtnl_lock_interruptible ())
+ break;
rtl8139_thread_iter (dev, tp, tp->mmio_addr);
rtnl_unlock ();
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] use rtnl_lock_interruptible in 8139 to avoid shutdown hang
2005-01-09 12:16 [PATCH 2/2] use rtnl_lock_interruptible in 8139 to avoid shutdown hang Christoph Hellwig
@ 2005-01-10 21:37 ` David S. Miller
2005-01-10 21:45 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: David S. Miller @ 2005-01-10 21:37 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: jgarzik, netdev
On Sun, 9 Jan 2005 13:16:30 +0100
Christoph Hellwig <hch@lst.de> wrote:
> The 8139too thread needs to use rtnl_lock_interruptible so it can avoid
> doing the actual work once it's been kill_proc()ed on module removal
> time.
>
> Based on debugging and an earlier patch that adds a driver-private
> semaphore from Herbert Xu.
I've applied these two patches, they look perfectly fine.
Thanks Christoph.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] use rtnl_lock_interruptible in 8139 to avoid shutdown hang
2005-01-10 21:37 ` David S. Miller
@ 2005-01-10 21:45 ` Christoph Hellwig
2005-01-11 1:50 ` David S. Miller
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2005-01-10 21:45 UTC (permalink / raw)
To: David S. Miller; +Cc: jgarzik, netdev
On Mon, Jan 10, 2005 at 01:37:14PM -0800, David S. Miller wrote:
> On Sun, 9 Jan 2005 13:16:30 +0100
> Christoph Hellwig <hch@lst.de> wrote:
>
> > The 8139too thread needs to use rtnl_lock_interruptible so it can avoid
> > doing the actual work once it's been kill_proc()ed on module removal
> > time.
> >
> > Based on debugging and an earlier patch that adds a driver-private
> > semaphore from Herbert Xu.
>
> I've applied these two patches, they look perfectly fine.
> Thanks Christoph.
Btw, there's some confusing between rtnl_lock and rtnl_shlock (similar
for the other variants). Is there an agenda behind this versions or
would you take a patch that unifies the lock assecors?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] use rtnl_lock_interruptible in 8139 to avoid shutdown hang
2005-01-10 21:45 ` Christoph Hellwig
@ 2005-01-11 1:50 ` David S. Miller
0 siblings, 0 replies; 4+ messages in thread
From: David S. Miller @ 2005-01-11 1:50 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: jgarzik, netdev
On Mon, 10 Jan 2005 22:45:22 +0100
Christoph Hellwig <hch@lst.de> wrote:
> Btw, there's some confusing between rtnl_lock and rtnl_shlock (similar
> for the other variants). Is there an agenda behind this versions or
> would you take a patch that unifies the lock assecors?
What exactly do you plan to change?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-01-11 1:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-09 12:16 [PATCH 2/2] use rtnl_lock_interruptible in 8139 to avoid shutdown hang Christoph Hellwig
2005-01-10 21:37 ` David S. Miller
2005-01-10 21:45 ` Christoph Hellwig
2005-01-11 1:50 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).