From: domen@coderock.org
To: kevin.curtis@farsite.co.uk
Cc: netdev@oss.sgi.com, domen@coderock.org, nacc@us.ibm.com,
janitor@sternwelten.at
Subject: [patch 1/1] net/farsync: add set_current_state() before schedule_timeout()
Date: Wed, 12 Jan 2005 00:07:43 +0100 [thread overview]
Message-ID: <20050111230744.403911F225@trashy.coderock.org> (raw)
Any comments would be appreciated.
Description: Insert set_current_state() before schedule_timeout() so the
function delays as expected. Without the addition, schedule_timeout()
will return immediately.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/drivers/net/wan/farsync.c | 1 +
1 files changed, 1 insertion(+)
diff -puN drivers/net/wan/farsync.c~set_current_state-drivers_net_wan_farsync drivers/net/wan/farsync.c
--- kj/drivers/net/wan/farsync.c~set_current_state-drivers_net_wan_farsync 2005-01-10 18:00:19.000000000 +0100
+++ kj-domen/drivers/net/wan/farsync.c 2005-01-10 18:00:19.000000000 +0100
@@ -981,6 +981,7 @@ fst_issue_cmd(struct fst_port_info *port
/* Wait for any previous command to complete */
while (mbval > NAK) {
spin_unlock_irqrestore(&card->card_lock, flags);
+ set_current_state(TASK_UNINTERRUPTIBLE);
schedule_timeout(1);
spin_lock_irqsave(&card->card_lock, flags);
_
next reply other threads:[~2005-01-11 23:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-11 23:07 domen [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-01-12 8:36 [patch 1/1] net/farsync: add set_current_state() before schedule_timeout() Kevin Curtis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050111230744.403911F225@trashy.coderock.org \
--to=domen@coderock.org \
--cc=janitor@sternwelten.at \
--cc=kevin.curtis@farsite.co.uk \
--cc=nacc@us.ibm.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).