* [patch 1/1] net/farsync: add set_current_state() before schedule_timeout()
@ 2005-01-11 23:07 domen
0 siblings, 0 replies; 2+ messages in thread
From: domen @ 2005-01-11 23:07 UTC (permalink / raw)
To: kevin.curtis; +Cc: netdev, domen, nacc, janitor
Any comments would be appreciated.
Description: Insert set_current_state() before schedule_timeout() so the
function delays as expected. Without the addition, schedule_timeout()
will return immediately.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/drivers/net/wan/farsync.c | 1 +
1 files changed, 1 insertion(+)
diff -puN drivers/net/wan/farsync.c~set_current_state-drivers_net_wan_farsync drivers/net/wan/farsync.c
--- kj/drivers/net/wan/farsync.c~set_current_state-drivers_net_wan_farsync 2005-01-10 18:00:19.000000000 +0100
+++ kj-domen/drivers/net/wan/farsync.c 2005-01-10 18:00:19.000000000 +0100
@@ -981,6 +981,7 @@ fst_issue_cmd(struct fst_port_info *port
/* Wait for any previous command to complete */
while (mbval > NAK) {
spin_unlock_irqrestore(&card->card_lock, flags);
+ set_current_state(TASK_UNINTERRUPTIBLE);
schedule_timeout(1);
spin_lock_irqsave(&card->card_lock, flags);
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [patch 1/1] net/farsync: add set_current_state() before schedule_timeout()
@ 2005-01-12 8:36 Kevin Curtis
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Curtis @ 2005-01-12 8:36 UTC (permalink / raw)
To: domen, Kevin Curtis; +Cc: netdev, nacc, janitor
This looks fine to me.
-----Original Message-----
From: domen@coderock.org [mailto:domen@coderock.org]
Sent: 11 January 2005 23:08
To: kevin.curtis@farsite.co.uk
Cc: netdev@oss.sgi.com; domen@coderock.org; nacc@us.ibm.com;
janitor@sternwelten.at
Subject: [patch 1/1] net/farsync: add set_current_state() before
schedule_timeout()
Any comments would be appreciated.
Description: Insert set_current_state() before schedule_timeout() so the
function delays as expected. Without the addition, schedule_timeout()
will return immediately.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/drivers/net/wan/farsync.c | 1 +
1 files changed, 1 insertion(+)
diff -puN
drivers/net/wan/farsync.c~set_current_state-drivers_net_wan_farsync
drivers/net/wan/farsync.c
---
kj/drivers/net/wan/farsync.c~set_current_state-drivers_net_wan_farsync
2005-01-10 18:00:19.000000000 +0100
+++ kj-domen/drivers/net/wan/farsync.c 2005-01-10 18:00:19.000000000
+0100
@@ -981,6 +981,7 @@ fst_issue_cmd(struct fst_port_info *port
/* Wait for any previous command to complete */
while (mbval > NAK) {
spin_unlock_irqrestore(&card->card_lock, flags);
+ set_current_state(TASK_UNINTERRUPTIBLE);
schedule_timeout(1);
spin_lock_irqsave(&card->card_lock, flags);
_
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-01-12 8:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-11 23:07 [patch 1/1] net/farsync: add set_current_state() before schedule_timeout() domen
-- strict thread matches above, loose matches on Subject: below --
2005-01-12 8:36 Kevin Curtis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).