* [patch 1/1] net/ltpc: replace schedule_timeout() with ssleep()/msleep()
@ 2005-01-11 23:08 domen
0 siblings, 0 replies; 2+ messages in thread
From: domen @ 2005-01-11 23:08 UTC (permalink / raw)
To: acme; +Cc: netdev, domen, nacc, janitor
Any comments would be appreciated.
Description: Use ssleep() / msleep() [as appropriate]
instead of schedule_timeout() to guarantee the task delays as expected.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Acked-by: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/drivers/net/appletalk/ltpc.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff -puN drivers/net/appletalk/ltpc.c~msleep+ssleep-drivers_net_appletalk_ltpc drivers/net/appletalk/ltpc.c
--- kj/drivers/net/appletalk/ltpc.c~msleep+ssleep-drivers_net_appletalk_ltpc 2005-01-10 18:00:14.000000000 +0100
+++ kj-domen/drivers/net/appletalk/ltpc.c 2005-01-10 18:00:14.000000000 +0100
@@ -1109,8 +1109,7 @@ struct net_device * __init ltpc_probe(vo
inb_p(io+1);
inb_p(io+3);
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(2*HZ/100);
+ msleep(20);
inb_p(io+0);
inb_p(io+2);
@@ -1120,8 +1119,7 @@ struct net_device * __init ltpc_probe(vo
inb_p(io+5); /* enable dma */
inb_p(io+6); /* tri-state interrupt line */
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(HZ);
+ ssleep(1);
/* now, figure out which dma channel we're using, unless it's
already been specified */
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* [patch 1/1] net/ltpc: replace schedule_timeout() with ssleep()/msleep()
@ 2005-03-05 15:47 domen
0 siblings, 0 replies; 2+ messages in thread
From: domen @ 2005-03-05 15:47 UTC (permalink / raw)
To: acme; +Cc: netdev, domen, nacc, janitor
Use ssleep() / msleep() [as appropriate]
instead of schedule_timeout() to guarantee the task delays as expected.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Acked-by: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/drivers/net/appletalk/ltpc.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff -puN drivers/net/appletalk/ltpc.c~msleep+ssleep-drivers_net_appletalk_ltpc drivers/net/appletalk/ltpc.c
--- kj/drivers/net/appletalk/ltpc.c~msleep+ssleep-drivers_net_appletalk_ltpc 2005-03-05 16:09:41.000000000 +0100
+++ kj-domen/drivers/net/appletalk/ltpc.c 2005-03-05 16:09:41.000000000 +0100
@@ -1109,8 +1109,7 @@ struct net_device * __init ltpc_probe(vo
inb_p(io+1);
inb_p(io+3);
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(2*HZ/100);
+ msleep(20);
inb_p(io+0);
inb_p(io+2);
@@ -1120,8 +1119,7 @@ struct net_device * __init ltpc_probe(vo
inb_p(io+5); /* enable dma */
inb_p(io+6); /* tri-state interrupt line */
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(HZ);
+ ssleep(1);
/* now, figure out which dma channel we're using, unless it's
already been specified */
_
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-03-05 15:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-11 23:08 [patch 1/1] net/ltpc: replace schedule_timeout() with ssleep()/msleep() domen
-- strict thread matches above, loose matches on Subject: below --
2005-03-05 15:47 domen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).