From: Don Fry <brazilnut@us.ibm.com>
To: domen@coderock.org
Cc: tsbogend@alpha.franken.de, netdev@oss.sgi.com, nacc@us.ibm.com,
janitor@sternwelten.at
Subject: Re: [patch 1/1] net/pcnet32: replace schedule_timeout() with msleep_interruptible()
Date: Tue, 11 Jan 2005 16:04:58 -0800 [thread overview]
Message-ID: <20050112000458.GA17834@us.ibm.com> (raw)
In-Reply-To: <20050111230150.1B6141F225@trashy.coderock.org>
Looks and runs fine.
Signed-off-by: Don Fry <brazilnut@us.ibm.com>
On Wed, Jan 12, 2005 at 12:01:49AM +0100, domen@coderock.org wrote:
>
>
>
> Any comments would be appreciated.
>
> Description: Use msleep_interruptible() instead of schedule_timeout() to
> guarantee the task delays as expected.
>
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
> Signed-off-by: Domen Puncer <domen@coderock.org>
> ---
>
>
> kj-domen/drivers/net/pcnet32.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/net/pcnet32.c~msleep_interruptible-drivers_net_pcnet32 drivers/net/pcnet32.c
> --- kj/drivers/net/pcnet32.c~msleep_interruptible-drivers_net_pcnet32 2005-01-10 18:00:07.000000000 +0100
> +++ kj-domen/drivers/net/pcnet32.c 2005-01-10 18:00:07.000000000 +0100
> @@ -847,7 +847,7 @@ static int pcnet32_phys_id(struct net_de
> if ((!data) || (data > (u32)(MAX_SCHEDULE_TIMEOUT / HZ)))
> data = (u32)(MAX_SCHEDULE_TIMEOUT / HZ);
>
> - schedule_timeout(data * HZ);
> + msleep_interruptible(data * 1000);
> del_timer_sync(&lp->blink_timer);
>
> /* Restore the original value of the bcrs */
> _
>
>
--
Don Fry
brazilnut@us.ibm.com
prev parent reply other threads:[~2005-01-12 0:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-11 23:01 [patch 1/1] net/pcnet32: replace schedule_timeout() with msleep_interruptible() domen
2005-01-12 0:04 ` Don Fry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050112000458.GA17834@us.ibm.com \
--to=brazilnut@us.ibm.com \
--cc=domen@coderock.org \
--cc=janitor@sternwelten.at \
--cc=nacc@us.ibm.com \
--cc=netdev@oss.sgi.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).