* [patch 1/1] net/pcnet32: replace schedule_timeout() with msleep_interruptible()
@ 2005-01-11 23:01 domen
2005-01-12 0:04 ` Don Fry
0 siblings, 1 reply; 2+ messages in thread
From: domen @ 2005-01-11 23:01 UTC (permalink / raw)
To: tsbogend; +Cc: netdev, domen, nacc, janitor
Any comments would be appreciated.
Description: Use msleep_interruptible() instead of schedule_timeout() to
guarantee the task delays as expected.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/drivers/net/pcnet32.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/net/pcnet32.c~msleep_interruptible-drivers_net_pcnet32 drivers/net/pcnet32.c
--- kj/drivers/net/pcnet32.c~msleep_interruptible-drivers_net_pcnet32 2005-01-10 18:00:07.000000000 +0100
+++ kj-domen/drivers/net/pcnet32.c 2005-01-10 18:00:07.000000000 +0100
@@ -847,7 +847,7 @@ static int pcnet32_phys_id(struct net_de
if ((!data) || (data > (u32)(MAX_SCHEDULE_TIMEOUT / HZ)))
data = (u32)(MAX_SCHEDULE_TIMEOUT / HZ);
- schedule_timeout(data * HZ);
+ msleep_interruptible(data * 1000);
del_timer_sync(&lp->blink_timer);
/* Restore the original value of the bcrs */
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 1/1] net/pcnet32: replace schedule_timeout() with msleep_interruptible()
2005-01-11 23:01 [patch 1/1] net/pcnet32: replace schedule_timeout() with msleep_interruptible() domen
@ 2005-01-12 0:04 ` Don Fry
0 siblings, 0 replies; 2+ messages in thread
From: Don Fry @ 2005-01-12 0:04 UTC (permalink / raw)
To: domen; +Cc: tsbogend, netdev, nacc, janitor
Looks and runs fine.
Signed-off-by: Don Fry <brazilnut@us.ibm.com>
On Wed, Jan 12, 2005 at 12:01:49AM +0100, domen@coderock.org wrote:
>
>
>
> Any comments would be appreciated.
>
> Description: Use msleep_interruptible() instead of schedule_timeout() to
> guarantee the task delays as expected.
>
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
> Signed-off-by: Domen Puncer <domen@coderock.org>
> ---
>
>
> kj-domen/drivers/net/pcnet32.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/net/pcnet32.c~msleep_interruptible-drivers_net_pcnet32 drivers/net/pcnet32.c
> --- kj/drivers/net/pcnet32.c~msleep_interruptible-drivers_net_pcnet32 2005-01-10 18:00:07.000000000 +0100
> +++ kj-domen/drivers/net/pcnet32.c 2005-01-10 18:00:07.000000000 +0100
> @@ -847,7 +847,7 @@ static int pcnet32_phys_id(struct net_de
> if ((!data) || (data > (u32)(MAX_SCHEDULE_TIMEOUT / HZ)))
> data = (u32)(MAX_SCHEDULE_TIMEOUT / HZ);
>
> - schedule_timeout(data * HZ);
> + msleep_interruptible(data * 1000);
> del_timer_sync(&lp->blink_timer);
>
> /* Restore the original value of the bcrs */
> _
>
>
--
Don Fry
brazilnut@us.ibm.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-01-12 0:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-11 23:01 [patch 1/1] net/pcnet32: replace schedule_timeout() with msleep_interruptible() domen
2005-01-12 0:04 ` Don Fry
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).