From: "David S. Miller" <davem@davemloft.net>
To: anton@samba.org
Cc: netdev@oss.sgi.com, herbert@gondor.apana.org.au
Subject: [DEBUG]: sk_forward_alloc assertion failures
Date: Thu, 13 Jan 2005 17:12:34 -0800 [thread overview]
Message-ID: <20050113171234.3fde0925.davem@davemloft.net> (raw)
Anton, can you and the other IBM folks who can reproduce
the problem give this test patch a whirl?
Herbert and I aren't exactly sure what the exact sequence
of events is that causes the problem, but we do know that
this code is highly suspect.
[ BTW, Herbert, it just occurred to me that these adjustments
are incorrect for the skb->data pulling case since we really
aren't liberating the data. ]
Thanks.
===== net/ipv4/tcp_output.c 1.75 vs edited =====
--- 1.75/net/ipv4/tcp_output.c 2004-12-28 10:22:40 -08:00
+++ edited/net/ipv4/tcp_output.c 2005-01-13 16:45:26 -08:00
@@ -580,12 +580,12 @@
TCP_SKB_CB(skb)->seq += len;
skb->ip_summed = CHECKSUM_HW;
-
+#if 0
skb->truesize -= len;
sk->sk_queue_shrunk = 1;
sk->sk_wmem_queued -= len;
sk->sk_forward_alloc += len;
-
+#endif
/* Any change of skb->len requires recalculation of tso
* factor and mss.
*/
next reply other threads:[~2005-01-14 1:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-14 1:12 David S. Miller [this message]
2005-01-14 1:25 ` [DEBUG]: sk_forward_alloc assertion failures Anton Blanchard
2005-01-14 4:19 ` David S. Miller
2005-01-14 11:16 ` Herbert Xu
2005-01-14 12:03 ` Herbert Xu
2005-01-14 19:03 ` David S. Miller
2005-01-14 20:34 ` Herbert Xu
2005-01-14 21:27 ` David S. Miller
2005-01-14 21:38 ` Herbert Xu
2005-01-14 21:36 ` David S. Miller
2005-01-14 21:55 ` Herbert Xu
2005-01-14 22:04 ` David S. Miller
2005-01-14 22:47 ` Herbert Xu
2005-01-15 4:55 ` David S. Miller
2005-01-15 5:45 ` Herbert Xu
2005-01-17 20:37 ` David S. Miller
2005-01-17 20:40 ` Herbert Xu
2005-01-14 21:34 ` Herbert Xu
2005-01-14 1:37 ` Herbert Xu
2005-01-14 4:09 ` David S. Miller
2005-01-14 1:50 ` Sridhar Samudrala
2005-01-14 2:10 ` Herbert Xu
2005-01-14 3:44 ` David S. Miller
-- strict thread matches above, loose matches on Subject: below --
2005-01-16 23:03 Nancy Milliner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050113171234.3fde0925.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anton@samba.org \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).