From: "David S. Miller" <davem@davemloft.net>
To: chas3@users.sourceforge.net
Cc: chas@cmf.nrl.navy.mil, netdev@oss.sgi.com
Subject: Re: [RFC] locking changes for lec.c
Date: Fri, 14 Jan 2005 20:33:51 -0800 [thread overview]
Message-ID: <20050114203351.14effe19.davem@davemloft.net> (raw)
In-Reply-To: <200501150232.j0F2Wovr010942@ginger.cmf.nrl.navy.mil>
On Fri, 14 Jan 2005 21:32:51 -0500
"chas williams - CONTRACTOR" <chas@cmf.nrl.navy.mil> wrote:
> In message <20050114135612.0edc180d.davem@davemloft.net>,"David S. Miller" writes:
> >Can HW interrupt paths ever call into this ARP stuff?
> >If not, probably should just use BH disabled locking
> >instead of the heavy handed IRQ disabling locks.
>
> yes, lec_push() could be run in hw interrupt context from one of of the
> atm drivers recv path. in fact, this is the path where i "noticed" the
> race condition.
Ok. As a future thought, if you make the ATM driver receive path
NAPI in style or run always from softint processing, you can
undo all the IRQ based locking.
prev parent reply other threads:[~2005-01-15 4:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-06 17:17 [RFC] locking changes for lec.c chas williams - CONTRACTOR
2005-01-14 21:56 ` David S. Miller
2005-01-15 2:32 ` chas williams - CONTRACTOR
2005-01-15 4:33 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050114203351.14effe19.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chas3@users.sourceforge.net \
--cc=chas@cmf.nrl.navy.mil \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).