From: "David S. Miller" <davem@davemloft.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: jgarzik@pobox.com, yoshfuji@linux-ipv6.org, netdev@oss.sgi.com
Subject: Re: "Badness" again
Date: Fri, 14 Jan 2005 21:06:51 -0800 [thread overview]
Message-ID: <20050114210651.654b22de.davem@davemloft.net> (raw)
In-Reply-To: <20050115002638.GA13849@gondor.apana.org.au>
On Sat, 15 Jan 2005 11:26:38 +1100
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> All your "badness" messages start with a call to udpv6_sendmsg().
> That function calls ip6_dst_lookup() to get its dst entry. Note
> that udpv6_sendmsg() does not hold a lock on the sk at all. However,
> ip6_dst_lookup() uses __sk_dst_check() which is only safe if you can
> either guarantee single-threadedness or if you hold sk_dst_lock.
Good catch, that looks to be it.
I wouldn't have caught the necessary dst_hold(*dst) removal
too, in fact I thought this hunk of your patch was a bug at
first :-)
I'll apply this, thanks a lot Herbert.
next prev parent reply other threads:[~2005-01-15 5:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <41E83B8D.8020003@pobox.com>
[not found] ` <20050114215833.GA12981@gondor.apana.org.au>
[not found] ` <41E844AC.6040200@pobox.com>
2005-01-15 0:26 ` "Badness" again Herbert Xu
2005-01-15 4:20 ` Jeff Garzik
2005-01-15 5:46 ` Herbert Xu
2005-01-15 5:06 ` David S. Miller [this message]
2005-01-15 5:13 ` YOSHIFUJI Hideaki / 吉藤英明
2005-01-15 10:39 ` Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050114210651.654b22de.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).