From: Andrew Morton <akpm@osdl.org>
To: Thomas Graf <tgraf@suug.ch>
Cc: davem@davemloft.net, netdev@oss.sgi.com
Subject: Re: [PATCH] PKT_SCHED: remove c99ism
Date: Sat, 15 Jan 2005 15:32:02 -0800 [thread overview]
Message-ID: <20050115153202.2f7f81c6.akpm@osdl.org> (raw)
In-Reply-To: <20050115232554.GS26856@postel.suug.ch>
Thomas Graf <tgraf@suug.ch> wrote:
>
> #ifdef CONFIG_NET_CLS_ACT
> - int err;
> - struct tc_action *act;
> -
> if (map->police && tb[map->police-1]) {
> + int err;
> + struct tc_action *act;
> act = tcf_action_init_1(tb[map->police-1], rate_tlv, "police",
> TCA_ACT_NOREPLACE, TCA_ACT_BIND, &err);
> if (act == NULL)
> @@ -498,6 +497,8 @@
> act->type = TCA_OLD_COMPAT;
> exts->action = act;
> } else if (map->action && tb[map->action-1]) {
> + int err;
> + struct tc_action *act;
> act = tcf_action_init(tb[map->action-1], rate_tlv, NULL,
> TCA_ACT_NOREPLACE, TCA_ACT_BIND, &err);
> if (act == NULL)
yes, that's the obvious one, but it uses a little more stack space.
An uglier but more efficient approach is to whack braces around the whole
thing.
next prev parent reply other threads:[~2005-01-15 23:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-15 22:40 c99ism in latest linus -bk Andrew Morton
2005-01-15 23:25 ` [PATCH] PKT_SCHED: remove c99ism Thomas Graf
2005-01-15 23:32 ` Andrew Morton [this message]
2005-01-15 23:40 ` Thomas Graf
2005-01-17 9:09 ` Herbert Poetzl
2005-01-17 11:56 ` Thomas Graf
2005-01-17 21:40 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050115153202.2f7f81c6.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).