netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: anton@samba.org, netdev@oss.sgi.com
Subject: Re: [DEBUG]: sk_forward_alloc assertion failures
Date: Mon, 17 Jan 2005 12:37:29 -0800	[thread overview]
Message-ID: <20050117123729.526ccdc7.davem@davemloft.net> (raw)
In-Reply-To: <20050115054547.GA15860@gondor.apana.org.au>

On Sat, 15 Jan 2005 16:45:47 +1100
Herbert Xu <herbert@gondor.apana.org.au> wrote:

> > +		if (sk->sk_forward_alloc < copy &&
> > +		    !sk_stream_mem_schedule(sk, copy, 0))
> 
> You want to have sk->sk_allocation here instead of 0.

The third argument to sk_stream_mem_schedule() is "int kind"
which is to be set to 1 for receive packet allocations and 0
for send packet allocations.

Why would I want to use a sk_allocation gfp mask here? :-)

  reply	other threads:[~2005-01-17 20:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-14  1:12 [DEBUG]: sk_forward_alloc assertion failures David S. Miller
2005-01-14  1:25 ` Anton Blanchard
2005-01-14  4:19   ` David S. Miller
2005-01-14 11:16     ` Herbert Xu
2005-01-14 12:03       ` Herbert Xu
2005-01-14 19:03         ` David S. Miller
2005-01-14 20:34           ` Herbert Xu
2005-01-14 21:27             ` David S. Miller
2005-01-14 21:38               ` Herbert Xu
2005-01-14 21:36                 ` David S. Miller
2005-01-14 21:55                   ` Herbert Xu
2005-01-14 22:04                     ` David S. Miller
2005-01-14 22:47                       ` Herbert Xu
2005-01-15  4:55                         ` David S. Miller
2005-01-15  5:45                           ` Herbert Xu
2005-01-17 20:37                             ` David S. Miller [this message]
2005-01-17 20:40                               ` Herbert Xu
2005-01-14 21:34         ` Herbert Xu
2005-01-14  1:37 ` Herbert Xu
2005-01-14  4:09   ` David S. Miller
2005-01-14  1:50 ` Sridhar Samudrala
2005-01-14  2:10   ` Herbert Xu
2005-01-14  3:44     ` David S. Miller
  -- strict thread matches above, loose matches on Subject: below --
2005-01-16 23:03 Nancy Milliner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050117123729.526ccdc7.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=anton@samba.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).