From: "David S. Miller" <davem@davemloft.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: tommy.christensen@tpack.net, simon.roscic@chello.at, netdev@oss.sgi.com
Subject: Re: [NETLINK] Do not netlink_unicast shared packet in kernel/audit.c
Date: Mon, 17 Jan 2005 13:36:40 -0800 [thread overview]
Message-ID: <20050117133640.0405d791.davem@davemloft.net> (raw)
In-Reply-To: <20050116080254.GA2997@gondor.apana.org.au>
On Sun, 16 Jan 2005 19:02:54 +1100
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> So here is a patch to handle shared skb's by cloning them if we're
> going to do a pskb_expand_head. This patch depends on the previous
> one that moves skb_orphan into netlink_trim.
I think this patch is buggy. At least in the final hunk, we
do this:
info.skb = skb;
...
skb = netlink_trim( ... );
Now info.skb can be pointing to a freed up skb.
I'll apply the first patch though.
next prev parent reply other threads:[~2005-01-17 21:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-23 23:02 Fwd: [2.6] ethertap and af_inet.c assertion failures Simon Roscic
2005-01-11 21:26 ` Tommy Christensen
2005-01-12 22:25 ` Simon Roscic
2005-01-15 13:31 ` Herbert Xu
2005-01-15 16:19 ` Tommy Christensen
2005-01-15 18:30 ` Herbert Xu
2005-01-15 20:20 ` Tommy Christensen
2005-01-16 8:02 ` [NETLINK] Do not netlink_unicast shared packet in kernel/audit.c Herbert Xu
2005-01-16 8:34 ` Tommy Christensen
2005-01-17 21:36 ` David S. Miller [this message]
2005-01-17 23:11 ` Herbert Xu
2005-01-19 22:33 ` David S. Miller
2005-01-15 18:03 ` Fwd: [2.6] ethertap and af_inet.c assertion failures Simon Roscic
2005-01-17 21:37 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050117133640.0405d791.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
--cc=simon.roscic@chello.at \
--cc=tommy.christensen@tpack.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).