From: "David S. Miller" <davem@davemloft.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: tommy.christensen@tpack.net, simon.roscic@chello.at, netdev@oss.sgi.com
Subject: Re: Fwd: [2.6] ethertap and af_inet.c assertion failures
Date: Mon, 17 Jan 2005 13:37:51 -0800 [thread overview]
Message-ID: <20050117133751.6d2421fa.davem@davemloft.net> (raw)
In-Reply-To: <E1Cpo1q-0007lI-00@gondolin.me.apana.org.au>
On Sun, 16 Jan 2005 00:31:46 +1100
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Tommy Christensen <tommy.christensen@tpack.net> wrote:
> >
> > netlink has messed up the send buffer accounting, when trimming a skb.
>
> You are spot on. Dave, you were right too about checking for charged
> skb's in netlink_trim.
It's good to know that I'm legitimately paranoid from time to
time :-)
> Since the skb will be orphaned on its way to the destination anyway,
> let's simply do that before the trimming. This shouldn't lead to
> skb leakage since the skb will either be charged to the destination
> socket or freed.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Looks good, I'll apply this.
Thanks Herbert.
prev parent reply other threads:[~2005-01-17 21:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-23 23:02 Fwd: [2.6] ethertap and af_inet.c assertion failures Simon Roscic
2005-01-11 21:26 ` Tommy Christensen
2005-01-12 22:25 ` Simon Roscic
2005-01-15 13:31 ` Herbert Xu
2005-01-15 16:19 ` Tommy Christensen
2005-01-15 18:30 ` Herbert Xu
2005-01-15 20:20 ` Tommy Christensen
2005-01-16 8:02 ` [NETLINK] Do not netlink_unicast shared packet in kernel/audit.c Herbert Xu
2005-01-16 8:34 ` Tommy Christensen
2005-01-17 21:36 ` David S. Miller
2005-01-17 23:11 ` Herbert Xu
2005-01-19 22:33 ` David S. Miller
2005-01-15 18:03 ` Fwd: [2.6] ethertap and af_inet.c assertion failures Simon Roscic
2005-01-17 21:37 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050117133751.6d2421fa.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
--cc=simon.roscic@chello.at \
--cc=tommy.christensen@tpack.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).