From: "David S. Miller" <davem@davemloft.net>
To: Dave Peterson <dsp@llnl.gov>
Cc: Robert.Olsson@data.slu.se, robert.olsson@its.uu.se, netdev@oss.sgi.com
Subject: Re: possible bug in net/core/pktgen.c (2.6.10 kernel)
Date: Tue, 18 Jan 2005 13:50:19 -0800 [thread overview]
Message-ID: <20050118135019.068ff57a.davem@davemloft.net> (raw)
In-Reply-To: <200501181346.22905.dsp@llnl.gov>
On Tue, 18 Jan 2005 13:46:22 -0800
Dave Peterson <dsp@llnl.gov> wrote:
> > Since when does do_softirq() need preemption disabled
> > around calls to it?
> >
> > do_softirq() disabled hard IRQs during the duration of it's
> > execution, thus effectively disabling preemption.
> >
> > What is the problematic case again?
>
> Oops... My mistake. Looking at __do_softirq() I noticed that it enables
> interrupts before executing the softirqs. However I didn't notice that
> the call to local_bh_disable() in __do_softirq() disables preemption
> before interrupts are enabled. On second thought everything looks OK
> and no bug fix is needed.
Great, looks like things are OK then.
prev parent reply other threads:[~2005-01-18 21:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-14 19:29 possible bug in net/core/pktgen.c (2.6.10 kernel) Dave Peterson
2005-01-16 12:46 ` Robert Olsson
2005-01-18 17:35 ` Dave Peterson
2005-01-18 20:41 ` David S. Miller
2005-01-18 21:46 ` Dave Peterson
2005-01-18 21:50 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050118135019.068ff57a.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Robert.Olsson@data.slu.se \
--cc=dsp@llnl.gov \
--cc=netdev@oss.sgi.com \
--cc=robert.olsson@its.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).