From: Daniele Venzano <webvenza@libero.it>
To: Jeff Garzik <jgarzik@pobox.com>, NetDev <netdev@oss.sgi.com>
Subject: [PATCH 3/5] sis900 printk audit
Date: Sat, 22 Jan 2005 22:46:59 +0100 (CET) [thread overview]
Message-ID: <20050122214659.18649.83119@localhost.localdomain> (raw)
In-Reply-To: <20050122214657.18649.66345@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 140 bytes --]
Change priority of printk where appropriate
Remove two cryptic and useless printk
Signed-off-by: Daniele Venzano <webvenza@libero.it>
[-- Attachment #2: Type: text/plain, Size: 3949 bytes --]
Index: sis900.c
===================================================================
--- a/drivers/net/sis900.c (revision 85)
+++ b/drivers/net/sis900.c (revision 86)
@@ -242,7 +242,7 @@
/* check to see if we have sane EEPROM */
signature = (u16) read_eeprom(ioaddr, EEPROMSignature);
if (signature == 0xffff || signature == 0x0000) {
- printk (KERN_INFO "%s: Error EERPOM read %x\n",
+ printk (KERN_WARNING "%s: Error EERPOM read %x\n",
net_dev->name, signature);
return 0;
}
@@ -275,7 +275,7 @@
if (!isa_bridge)
isa_bridge = pci_get_device(PCI_VENDOR_ID_SI, 0x0018, isa_bridge);
if (!isa_bridge) {
- printk("%s: Can not find ISA bridge\n", net_dev->name);
+ printk(KERN_WARNING "%s: Can not find ISA bridge\n", net_dev->name);
return 0;
}
pci_read_config_byte(isa_bridge, 0x48, ®);
@@ -567,7 +567,7 @@
continue;
if ((mii_phy = kmalloc(sizeof(struct mii_phy), GFP_KERNEL)) == NULL) {
- printk(KERN_INFO "Cannot allocate mem for struct mii_phy\n");
+ printk(KERN_WARNING "Cannot allocate mem for struct mii_phy\n");
mii_phy = sis_priv->first_mii;
while (mii_phy) {
struct mii_phy *phy;
@@ -1029,7 +1029,7 @@
outl(w, ioaddr + rfdr);
if (sis900_debug > 2) {
- printk(KERN_INFO "%s: Receive Filter Addrss[%d]=%x\n",
+ printk(KERN_DEBUG "%s: Receive Filter Addrss[%d]=%x\n",
net_dev->name, i, inl(ioaddr + rfdr));
}
}
@@ -1067,7 +1067,7 @@
/* load Transmit Descriptor Register */
outl(sis_priv->tx_ring_dma, ioaddr + txdp);
if (sis900_debug > 2)
- printk(KERN_INFO "%s: TX descriptor register loaded with: %8.8x\n",
+ printk(KERN_DEBUG "%s: TX descriptor register loaded with: %8.8x\n",
net_dev->name, inl(ioaddr + txdp));
}
@@ -1121,7 +1121,7 @@
/* load Receive Descriptor Register */
outl(sis_priv->rx_ring_dma, ioaddr + rxdp);
if (sis900_debug > 2)
- printk(KERN_INFO "%s: RX descriptor register loaded with: %8.8x\n",
+ printk(KERN_DEBUG "%s: RX descriptor register loaded with: %8.8x\n",
net_dev->name, inl(ioaddr + rxdp));
}
@@ -1571,7 +1571,7 @@
net_dev->trans_start = jiffies;
if (sis900_debug > 3)
- printk(KERN_INFO "%s: Queued Tx packet at %p size %d "
+ printk(KERN_DEBUG "%s: Queued Tx packet at %p size %d "
"to slot %d.\n",
net_dev->name, skb->data, (int)skb->len, entry);
@@ -1631,7 +1631,7 @@
} while (1);
if (sis900_debug > 3)
- printk(KERN_INFO "%s: exiting interrupt, "
+ printk(KERN_DEBUG "%s: exiting interrupt, "
"interrupt status = 0x%#8.8x.\n",
net_dev->name, inl(ioaddr + isr));
@@ -1657,7 +1657,7 @@
u32 rx_status = sis_priv->rx_ring[entry].cmdsts;
if (sis900_debug > 3)
- printk(KERN_INFO "sis900_rx, cur_rx:%4.4d, dirty_rx:%4.4d "
+ printk(KERN_DEBUG "sis900_rx, cur_rx:%4.4d, dirty_rx:%4.4d "
"status:0x%8.8x\n",
sis_priv->cur_rx, sis_priv->dirty_rx, rx_status);
@@ -1669,7 +1669,7 @@
if (rx_status & (ABORT|OVERRUN|TOOLONG|RUNT|RXISERR|CRCERR|FAERR)) {
/* corrupted packet received */
if (sis900_debug > 3)
- printk(KERN_INFO "%s: Corrupted packet "
+ printk(KERN_DEBUG "%s: Corrupted packet "
"received, buffer status = 0x%8.8x.\n",
net_dev->name, rx_status);
sis_priv->stats.rx_errors++;
@@ -1807,7 +1807,7 @@
if (tx_status & (ABORT | UNDERRUN | OWCOLL)) {
/* packet unsuccessfully transmitted */
if (sis900_debug > 3)
- printk(KERN_INFO "%s: Transmit "
+ printk(KERN_DEBUG "%s: Transmit "
"error, Tx status %8.8x.\n",
net_dev->name, tx_status);
sis_priv->stats.tx_errors++;
@@ -2074,12 +2074,10 @@
case IF_PORT_AUI: /* AUI */
case IF_PORT_100BASEFX: /* 100BaseFx */
/* These Modes are not supported (are they?)*/
- printk(KERN_INFO "Not supported");
return -EOPNOTSUPP;
break;
default:
- printk(KERN_INFO "Invalid");
return -EINVAL;
}
}
next prev parent reply other threads:[~2005-01-22 21:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-22 21:46 [PATCH 1/5] sis900 printk audit Daniele Venzano
2005-01-22 21:46 ` [PATCH 2/5] " Daniele Venzano
2005-01-22 21:46 ` Daniele Venzano [this message]
2005-01-22 22:26 ` [PATCH 3/5] " Francois Romieu
2005-01-23 9:10 ` [PATCH 6/5] " Daniele Venzano
2005-01-22 21:47 ` [PATCH 4/5] " Daniele Venzano
2005-01-22 21:47 ` [PATCH 5/5] " Daniele Venzano
2005-01-22 22:26 ` [PATCH 1/5] " Francois Romieu
2005-01-23 8:52 ` Daniele Venzano
2005-01-23 16:16 ` Francois Romieu
2005-01-23 18:31 ` Daniele Venzano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050122214659.18649.83119@localhost.localdomain \
--to=webvenza@libero.it \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).