netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr.zoreil.com>
To: Richard Dawe <rich@phekda.gotadsl.co.uk>
Cc: netdev@oss.sgi.com
Subject: Re: Acer Aspire 1524WLMi and RealTek 8169 - very slow
Date: Sun, 23 Jan 2005 00:01:56 +0100	[thread overview]
Message-ID: <20050122230156.GC24461@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <41F26FD1.2060407@phekda.gotadsl.co.uk>

Richard Dawe <rich@phekda.gotadsl.co.uk> :
[...]
> So I looked at the latest RealTek driver for Linux (version 220) and 
> that has some separate initialisation code for RTL_GIGA_MAC_VER_X 
> (MCFG_METHOD_4, they call it). I ported that over to r8169.c in 
> 2.6.11-rc1 and it appears to work.

Nice. Have you checked that ethtool performs correctly when you try to
set the link parameters with the new code (+ plug/unplug cable) ?

> Attached is the patch against 2.6.11-rc1. I'm not sure if it caters to 
> your tastes. Maybe you'll want to rename RTL_GIGA_MAC_VER_X. 

I'll change the braces placement, the tab/spaces mix and push it.

Please include something like the line below in your future patches:
Signed-off-by: Richard Dawe <rich@phekda.gotadsl.co.uk>

Thanks.

--
Ueimor

  reply	other threads:[~2005-01-22 23:01 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-21 13:16 Acer Aspire 1524WLMi and RealTek 8169 - very slow Richard Dawe
2004-11-21 13:24 ` Richard Dawe
2004-11-21 19:47 ` Richard Dawe
2004-11-21 20:58   ` Francois Romieu
2004-11-22 20:42     ` Richard Dawe
2004-11-22 21:30       ` Francois Romieu
2004-11-22 22:07         ` Richard Dawe
2004-11-24 19:36         ` Richard Dawe
2004-11-30 19:52           ` Jon Mason
2004-12-29 10:17         ` Richard Dawe
2004-12-29 23:52           ` Francois Romieu
2005-01-02 13:51             ` Richard Dawe
2005-01-02 15:23               ` Richard Dawe
2005-01-22 13:10             ` Richard Dawe
2005-01-22 15:22               ` Richard Dawe
2005-01-22 23:01                 ` Francois Romieu [this message]
2005-01-23 19:08                   ` Richard Dawe
2005-01-25 21:47                     ` Francois Romieu
2005-02-05 13:26                       ` Richard Dawe
2005-02-05 20:41                         ` Francois Romieu
2005-02-06 10:54                           ` Richard Dawe
2005-02-08 23:00                           ` Richard Dawe
2005-02-12  0:07                             ` Francois Romieu
2004-11-21 23:28 ` [patch] ethtool (was Re: Acer Aspire 1524WLMi and RealTek 8169 - very slow) Francois Romieu
2005-01-27 20:27   ` Jeff Garzik
  -- strict thread matches above, loose matches on Subject: below --
2005-01-26 22:00 Acer Aspire 1524WLMi and RealTek 8169 - very slow Brandeburg, Jesse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050122230156.GC24461@electric-eye.fr.zoreil.com \
    --to=romieu@fr.zoreil.com \
    --cc=netdev@oss.sgi.com \
    --cc=rich@phekda.gotadsl.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).