From: Daniele Venzano <webvenza@libero.it>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, NetDev <netdev@oss.sgi.com>
Subject: Re: [PATCH 1/5] sis900 printk audit
Date: Sun, 23 Jan 2005 09:52:29 +0100 [thread overview]
Message-ID: <20050123085229.GD31816@gateway.milesteg.arr> (raw)
In-Reply-To: <20050122222640.GB24461@electric-eye.fr.zoreil.com>
On Sat, Jan 22, 2005 at 11:26:40PM +0100, Francois Romieu wrote:
> Daniele Venzano <webvenza@libero.it> :
> [...]
> > Index: sis900.c
> > ===================================================================
> > --- a/drivers/net/sis900.c (revision 83)
> > +++ b/drivers/net/sis900.c (revision 84)
> [...]
> > @@ -1906,8 +1918,22 @@
> > strcpy (info->bus_info, pci_name(sis_priv->pci_dev));
> > }
> >
> > +static u32 sis900_get_msglevel(struct net_device *net_dev)
> > +{
> > + struct sis900_private *sis_priv = net_dev->priv;
>
> s/net_dev->priv/netdev_priv/
I don't understand, what's wrong here ?
Is that a suggestion that I make some global variable or macro to avoid
repeating that declaration in almost every function of the driver ?
--
-----------------------------
Daniele Venzano
Web: http://teg.homeunix.org
next prev parent reply other threads:[~2005-01-23 8:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-22 21:46 [PATCH 1/5] sis900 printk audit Daniele Venzano
2005-01-22 21:46 ` [PATCH 2/5] " Daniele Venzano
2005-01-22 21:46 ` [PATCH 3/5] " Daniele Venzano
2005-01-22 22:26 ` Francois Romieu
2005-01-23 9:10 ` [PATCH 6/5] " Daniele Venzano
2005-01-22 21:47 ` [PATCH 4/5] " Daniele Venzano
2005-01-22 21:47 ` [PATCH 5/5] " Daniele Venzano
2005-01-22 22:26 ` [PATCH 1/5] " Francois Romieu
2005-01-23 8:52 ` Daniele Venzano [this message]
2005-01-23 16:16 ` Francois Romieu
2005-01-23 18:31 ` Daniele Venzano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050123085229.GD31816@gateway.milesteg.arr \
--to=webvenza@libero.it \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).