From: "David S. Miller" <davem@davemloft.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@oss.sgi.com
Subject: Re: design for TSO performance fix
Date: Fri, 28 Jan 2005 11:28:38 -0800 [thread overview]
Message-ID: <20050128112838.21e53b6c.davem@davemloft.net> (raw)
In-Reply-To: <20050128054441.GA8260@gondor.apana.org.au>
On Fri, 28 Jan 2005 16:44:41 +1100
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Colour me confused then. How are you going to remember the
> packet boundaries which we need to do if we're going to keep
> counting packets instead of bytes?
It's just like how the code was before I added all of
that tcp_pcount_t code. The retransmit queue only
ever contains normal MSS sized frames.
When we decide to send something off the queue, we try
to build them up into TSO frames.
Congestion control etc. decisions are still made by packet
counting.
When we get ACKs and SACKs back, we can just trim and mark the
retransmit queue in the simplest way since we don't have
TSO packets in there anymore.
TSO packets only exist in the tcp_transmit_skb() path,
nothing else in the stack sees them.
next prev parent reply other threads:[~2005-01-28 19:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-28 0:31 design for TSO performance fix David S. Miller
2005-01-28 0:51 ` Rick Jones
2005-01-28 0:58 ` David S. Miller
2005-01-28 1:31 ` Herbert Xu
2005-01-28 5:19 ` David S. Miller
2005-01-28 5:44 ` Herbert Xu
2005-01-28 19:28 ` David S. Miller [this message]
2005-01-29 10:12 ` Herbert Xu
2005-01-28 1:57 ` Thomas Graf
2005-02-01 23:04 ` David S. Miller
2005-01-28 6:25 ` Andi Kleen
2005-01-28 6:44 ` Nivedita Singhvi
2005-01-28 19:30 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050128112838.21e53b6c.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).