From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Thomas Graf <tgraf@suug.ch>,
davem@davemloft.net, kuznet@ms2.inr.ac.ru, netdev@oss.sgi.com
Subject: Re: [PATCH] NETLINK: Use SKB_MAXORDER to calculate NLMSG_GOODSIZE
Date: Sat, 29 Jan 2005 02:48:28 +0300 [thread overview]
Message-ID: <20050128234828.GA24868@yakov.inr.ac.ru> (raw)
In-Reply-To: <E1CufRB-0000zf-00@gondolin.me.apana.org.au>
Hello!
> > -#define NLMSG_GOODSIZE (PAGE_SIZE - ((sizeof(struct sk_buff)+0xF)&~0xF))
... which reminded me about an old stale patchlet:
Comment: improper size calculation for collapsed skb size.
Noticed by Denis V. Lunev <den@asplinux.ru>
===== net/ipv4/tcp_input.c 1.89 vs edited =====
--- 1.89/net/ipv4/tcp_input.c Tue Jan 18 01:09:33 2005
+++ edited/net/ipv4/tcp_input.c Thu Jan 27 19:41:07 2005
@@ -3760,8 +3760,8 @@
while (before(start, end)) {
struct sk_buff *nskb;
int header = skb_headroom(skb);
- int copy = (PAGE_SIZE - sizeof(struct sk_buff) -
- sizeof(struct skb_shared_info) - header - 31)&~15;
+ int copy = (PAGE_SIZE - sizeof(struct skb_shared_info)
+ - header - 31)&~15;
/* Too big header? This can happen with IPv6. */
if (copy < 0)
next prev parent reply other threads:[~2005-01-28 23:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-28 23:03 [PATCH] NETLINK: Use SKB_MAXORDER to calculate NLMSG_GOODSIZE Thomas Graf
2005-01-28 23:22 ` Herbert Xu
2005-01-28 23:40 ` Thomas Graf
2005-02-07 6:27 ` David S. Miller
2005-01-28 23:48 ` Alexey Kuznetsov [this message]
2005-01-29 0:21 ` Thomas Graf
2005-01-29 0:27 ` Thomas Graf
2005-02-07 6:32 ` David S. Miller
2005-02-07 13:28 ` Thomas Graf
2005-02-07 14:27 ` [PATCH] NET: Fix calculation for collapsed skb size Thomas Graf
2005-02-09 4:54 ` David S. Miller
2005-01-29 18:40 ` [PATCH] NETLINK: Use SKB_MAXORDER to calculate NLMSG_GOODSIZE Alexey Kuznetsov
2005-01-29 12:47 ` Thomas Graf
2005-02-06 18:54 ` Thomas Graf
2005-02-06 21:08 ` David S. Miller
2005-02-07 6:25 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050128234828.GA24868@yakov.inr.ac.ru \
--to=kuznet@ms2.inr.ac.ru \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).