From: Horms <horms@verge.net.au>
To: Andrew Morton <akpm@osdl.org>
Cc: davem@davemloft.net, netdev@oss.sgi.com
Subject: Re: [patch 2/2] ipvs deadlock fix
Date: Mon, 31 Jan 2005 13:21:12 +0300 [thread overview]
Message-ID: <20050131102111.GA6279@verge.net.au> (raw)
In-Reply-To: <20050131014722.77d732c4.akpm@osdl.org>
On Mon, Jan 31, 2005 at 01:47:22AM -0800, Andrew Morton wrote:
> Horms <horms@verge.net.au> wrote:
> >
> > On Sun, Jan 30, 2005 at 10:33:02PM -0800, akpm@osdl.org wrote:
> > >
> > >
> > > update_defense_level() is calling si_meminfo() from timer context. But
> > > si_meminfo takes non-irq-safe locks.
> > >
> > > Move it all to keventd context.
> >
> > Would I be right in thinking that the offending lock is bdev_lock which
> > is grabbed in nr_blockdev_pages() and thus that this is not an issue
> > for 2.4 whose si_meminfo() does not have such a call?
>
> Yes, 2.4's si_meminfo() seems to be OK from interrupt context.
Thanks.
> On x86 - I didn't check the other architectures.
Me neither.
--
Horms
next prev parent reply other threads:[~2005-01-31 10:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-31 6:33 [patch 2/2] ipvs deadlock fix akpm
2005-01-31 9:36 ` Horms
2005-01-31 9:47 ` Andrew Morton
2005-01-31 10:21 ` Horms [this message]
2005-02-15 22:27 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050131102111.GA6279@verge.net.au \
--to=horms@verge.net.au \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).