From: linux@horizon.com
To: lorenzo@gnu.org, mingo@elte.hu
Cc: arjan@infradead.org, bunk@stusta.de, chrisw@osdl.org,
davem@redhat.com, hlein@progressive-comp.com,
linux-kernel@vger.kernel.org, linux@horizon.com,
netdev@oss.sgi.com, shemminger@osdl.org, Valdis.Kletnieks@vt.edu
Subject: Re: [PATCH] OpenBSD Networking-related randomization port
Date: 31 Jan 2005 23:27:35 -0000 [thread overview]
Message-ID: <20050131232735.11236.qmail@science.horizon.com> (raw)
In-Reply-To: <20050131201141.GA4879@elte.hu>
> could you please also react to this feedback:
>
> http://marc.theaimsgroup.com/?l=linux-kernel&m=110698371131630&w=2
>
> to quote a couple of key points from that very detailed security
> analysis:
>
> " I'm not sure how the OpenBSD code is better in any way. (Notice that
> it uses the same "half_md4_transform" as Linux; you just added another
> copy.) Is there a design note on how the design was chosen? "
Just note that, in addition to the security aspects, there are also a
whole set of multiprocessor issues. OpenBSD added SMP support in June
2004, and it looks like this code dates back to before that. It might
be worth looking at what OpenBSD does now.
Note that I have NOT looked at the patch other than the TCP ISN
generation. However, given the condition of the ISN code, I am inclined
to take a "guilty until proven innocent" view of the rest of it.
Don't merge it until someone has really grokked it, not just kibitzed
about code style issues.
(The homebrew 15-bit block cipher in this code does show how much the
world needs a small block cipher for some of these applications.)
next prev parent reply other threads:[~2005-01-31 23:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1106932637.3778.92.camel@localhost.localdomain>
[not found] ` <20050128174046.GR28047@stusta.de>
[not found] ` <1106934475.3778.98.camel@localhost.localdomain>
2005-01-28 18:18 ` [PATCH] OpenBSD Networking-related randomization port Stephen Hemminger
2005-01-28 18:54 ` Lorenzo Hernández García-Hierro
[not found] ` <20050128100229.5c0e4ea1@dxpl.pdx.osdl.net>
2005-01-28 18:31 ` Lorenzo Hernández García-Hierro
2005-01-28 18:52 ` Stephen Hemminger
2005-01-28 18:58 ` Lorenzo Hernández García-Hierro
2005-01-28 20:34 ` Lorenzo Hernández García-Hierro
2005-01-28 20:45 ` David S. Miller
2005-01-28 21:34 ` Stephen Hemminger
2005-01-28 21:45 ` David S. Miller
2005-01-29 6:59 ` Andi Kleen
2005-01-28 20:47 ` Arjan van de Ven
2005-01-28 22:12 ` Lorenzo Hernández García-Hierro
2005-01-29 8:04 ` Arjan van de Ven
2005-01-29 8:05 ` Arjan van de Ven
2005-01-29 9:15 ` Valdis.Kletnieks
2005-01-31 16:50 ` Adrian Bunk
2005-01-31 17:23 ` Lorenzo Hernández García-Hierro
2005-01-31 20:11 ` Ingo Molnar
2005-01-31 23:27 ` linux [this message]
2005-02-12 22:29 ` Andi Kleen
2005-02-12 23:25 ` linux
2005-02-13 0:18 ` Roland Dreier
2005-02-13 1:41 ` linux
2005-02-02 17:17 ` linux
2005-02-02 17:38 ` Lorenzo Hernández García-Hierro
2005-02-03 19:51 ` Stephen Hemminger
2005-02-03 20:14 ` Lennert Buytenhek
2005-01-31 19:42 ` Valdis.Kletnieks
2005-01-31 20:03 ` Lorenzo Hernández García-Hierro
2005-02-01 23:22 ` Matt Mackall
[not found] ` <1106935677.7776.29.camel@laptopd505.fenrus.org>
2005-01-28 18:36 ` Lorenzo Hernández García-Hierro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050131232735.11236.qmail@science.horizon.com \
--to=linux@horizon.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=arjan@infradead.org \
--cc=bunk@stusta.de \
--cc=chrisw@osdl.org \
--cc=davem@redhat.com \
--cc=hlein@progressive-comp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@gnu.org \
--cc=mingo@elte.hu \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).