netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: mirko.parthey@informatik.tu-chemnitz.de,
	linux-kernel@vger.kernel.org, netdev@oss.sgi.com,
	yoshfuji@linux-ipv6.org, shemminger@osdl.org
Subject: Re: PROBLEM: 2.6.11-rc2 hangs on bridge shutdown (br0)
Date: Fri, 4 Feb 2005 21:38:13 -0800	[thread overview]
Message-ID: <20050204213813.4bd642ad.davem@davemloft.net> (raw)
In-Reply-To: <20050205052407.GA17266@gondor.apana.org.au>

On Sat, 5 Feb 2005 16:24:07 +1100
Herbert Xu <herbert@gondor.apana.org.au> wrote:

> This is the key to the problem.
 ...
> All of these bugs stem from the idev reference held in rtable/rt6_info.
 ...
> Anyway, this particular problem is due to IPv6 adding local addresses
> with split devices.  That is, routes to local addresses are added with
> rt6i_dev set to &loopback_dev and rt6i_idev set to the idev of the
> device where the address is added.
 ...
> It also goes against the Linux philosophy where the addresses are owned
> by the host, not the interface.
> 
> Therefore I propose the simple solution of not doing the split device
> accounting in rt6_info.

I agree with your analysis, however... this change is not sufficient.
You have to then walk over all the uses of rt6i_dev and sanitize the
cases that still expect the split semantics.  For example, things like
this piece of coe in rt6_device_match():

			if (dev->flags & IFF_LOOPBACK) {
				if (sprt->rt6i_idev == NULL ||
				    sprt->rt6i_idev->dev->ifindex != oif) {
					if (strict && oif)
						continue;
					if (local && (!oif || 
						      local->rt6i_idev->dev->ifindex == oif))
						continue;
				}
				local = sprt;
			}

It is just the first such thing I found, scanning rt6i_idev uses
will easily find several others.

  reply	other threads:[~2005-02-05  5:38 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20050131162201.GA1000@stilzchen.informatik.tu-chemnitz.de>
2005-02-05  5:24 ` PROBLEM: 2.6.11-rc2 hangs on bridge shutdown (br0) Herbert Xu
2005-02-05  5:38   ` David S. Miller [this message]
2005-02-05  6:11     ` Herbert Xu
2005-02-05  6:13       ` David S. Miller
2005-02-05  6:46         ` Herbert Xu
2005-02-05 10:45           ` Herbert Xu
2005-02-06 11:41             ` Herbert Xu
2005-02-06 12:30               ` YOSHIFUJI Hideaki / 吉藤英明
2005-02-06 21:01                 ` Herbert Xu
2005-02-09 20:45                 ` Andre Tomt
2005-02-05 10:50           ` YOSHIFUJI Hideaki / 吉藤英明
2005-02-05 18:32             ` Herbert Xu
2005-02-06  4:02             ` David S. Miller
2005-02-06  5:01               ` YOSHIFUJI Hideaki / 吉藤英明
2005-02-06  4:10           ` David S. Miller
2005-02-06  4:37             ` YOSHIFUJI Hideaki / 吉藤英明
2005-02-06  5:04               ` David S. Miller
2005-02-06  5:31                 ` YOSHIFUJI Hideaki / 吉藤英明
2005-02-06  5:50                   ` YOSHIFUJI Hideaki / 吉藤英明
2005-02-06  7:00                     ` Herbert Xu
2005-02-06  6:53                   ` Herbert Xu
2005-02-06  6:52                 ` Herbert Xu
2005-02-06  6:51             ` Herbert Xu
2005-02-08  1:29               ` [IPSEC] Move dst->child loop from dst_ifdown to xfrm_dst_ifdown Herbert Xu
2005-02-08  1:31                 ` Herbert Xu
2005-02-15 22:53                   ` David S. Miller
2005-02-05 11:14       ` PROBLEM: 2.6.11-rc2 hangs on bridge shutdown (br0) Andre Tomt
2005-02-05 11:39         ` YOSHIFUJI Hideaki / 吉藤英明
2005-02-05 11:48           ` Andre Tomt
2005-02-05 11:55             ` YOSHIFUJI Hideaki / 吉藤英明
2005-02-05 18:33           ` Herbert Xu
2005-02-06 10:55       ` Andre Tomt
2005-02-06 11:28         ` YOSHIFUJI Hideaki / 吉藤英明

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050204213813.4bd642ad.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mirko.parthey@informatik.tu-chemnitz.de \
    --cc=netdev@oss.sgi.com \
    --cc=shemminger@osdl.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).