netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [IPV6]: Fix tunnel list locking in ip6_tunnel.c.
@ 2005-02-04 16:56 YOSHIFUJI Hideaki / 吉藤英明
  2005-02-07  6:05 ` David S. Miller
  0 siblings, 1 reply; 2+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2005-02-04 16:56 UTC (permalink / raw)
  To: davem; +Cc: yoshfuji, netdev

Hello.

We need to fix tunnel list locking in ip6_tunnel.c as well.
Noticed by jean-mickael guerin <jean-mickael.guerin@6WIND.com>.

Signed-off-by: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>

===== net/ipv6/ip6_tunnel.c 1.27 vs edited =====
--- 1.27/net/ipv6/ip6_tunnel.c	2005-01-14 13:41:06 +09:00
+++ edited/net/ipv6/ip6_tunnel.c	2005-02-05 01:50:53 +09:00
@@ -180,10 +180,10 @@
 {
 	struct ip6_tnl **tp = ip6ip6_bucket(&t->parms);
 
-	write_lock_bh(&ip6ip6_lock);
 	t->next = *tp;
-	write_unlock_bh(&ip6ip6_lock);
+	write_lock_bh(&ip6ip6_lock);
 	*tp = t;
+	write_unlock_bh(&ip6ip6_lock);
 }
 
 /**

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [IPV6]: Fix tunnel list locking in ip6_tunnel.c.
  2005-02-04 16:56 [IPV6]: Fix tunnel list locking in ip6_tunnel.c YOSHIFUJI Hideaki / 吉藤英明
@ 2005-02-07  6:05 ` David S. Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2005-02-07  6:05 UTC (permalink / raw)
  To: yoshfuji; +Cc: netdev

On Sat, 05 Feb 2005 01:56:33 +0900 (JST)
YOSHIFUJI Hideaki / ^[$B5HF#1QL@^[(B <yoshfuji@linux-ipv6.org> wrote:

> We need to fix tunnel list locking in ip6_tunnel.c as well.
> Noticed by jean-mickael guerin <jean-mickael.guerin@6WIND.com>.
> 
> Signed-off-by: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>

Applied.  Arigato gozaimasu, Yoshifuji-san.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-02-07  6:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-04 16:56 [IPV6]: Fix tunnel list locking in ip6_tunnel.c YOSHIFUJI Hideaki / 吉藤英明
2005-02-07  6:05 ` David S. Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).