From mboxrd@z Thu Jan  1 00:00:00 1970
From: "David S. Miller" <davem@davemloft.net>
Subject: Re: [Bonding-devel] Re: [Bugme-new] [Bug 4189] New: IPv6 link local
 addresses are not assigned correctly on multiple-bonding enviromrnts
Date: Thu, 10 Feb 2005 19:44:54 -0800
Message-ID: <20050210194454.015f3d98.davem@davemloft.net>
References: <20050210122745.16ca7cb3.davem@davemloft.net>
	<200502110240.j1B2eTj3001689@death.nxdomain.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: yoshfuji@linux-ipv6.org, netdev@oss.sgi.com, ikebe.takashi@lab.ntt.co.jp,
        akpm@osdl.org, ctindel@users.sourceforge.net,
        bonding-devel@lists.sourceforge.net
Return-path: <netdev-bounce@oss.sgi.com>
To: Jay Vosburgh <fubar@us.ibm.com>
In-Reply-To: <200502110240.j1B2eTj3001689@death.nxdomain.ibm.com>
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
List-Id: netdev.vger.kernel.org

On Thu, 10 Feb 2005 18:40:29 -0800
Jay Vosburgh <fubar@us.ibm.com> wrote:

> 	Except that most of the bonding internal MAC changes won't
> generate any events (presuming you mean a NETDEV_CHANGEADDR).  The
> bonding driver calls the slave's dev->set_mac_address directly; the
> NETDEV_CHANGEADDR is generated by dev_ifsioc() (which isn't exported).
> Now that I'm looking for it, there are some other cases of bonding
> calling other dev->functions directly, e.g., change_mtu, that have
> wrappers that generate events; I need to fix that.
> 
> 	Would you have a problem with putting the SIOCSIFHWADDR code
> from dev_ifsioc() into a separate exported function, similarly to how
> dev_set_mtu() is done?  I can probably whip that up along with the
> appropriate bonding changes this evening.

That would be a great idea, as I read your first paragraph I was
going to suggest exactly this.