From: "David S. Miller" <davem@davemloft.net>
To: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Cc: shemminger@osdl.org, hubert.tonneau@fullpliant.org,
romieu@fr.zoreil.com, kuznet@ms2.inr.ac.ru, niv@us.ibm.com,
rick.jones2@hp.com, netdev@oss.sgi.com
Subject: Re: 2.6.10 TCP troubles -- suggested patch
Date: Sat, 12 Feb 2005 11:41:32 -0800 [thread overview]
Message-ID: <20050212114132.5f7b7ffe.davem@davemloft.net> (raw)
In-Reply-To: <20050212141641.GA27456@yakov.inr.ac.ru>
On Sat, 12 Feb 2005 17:16:41 +0300
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru> wrote:
> > This set of data frames you quoted are all full, and
> > are tightly interspaced. It looks exactly like a TSO
> > frame, which we certainly set PSH on, but the TSO
> > engine is dropping it aparently.
...
> Or it was two one-segment frames.
Even ignoring my TSO changes, we should be seeing at a minimum
1/2 window PSH settings which we're not as far as I can tell.
(this is due to the forced_push() test in net/ipv4/tcp.c)
This also points out a bug in my TSO PSH patch, I should be
updating tp->pushed_seq shouldn't I? Question is, what to
set it to? I think correct value is TCP_SKB_CB(skb)->end_seq.
> I.e. let's disable TSO in 2.6.9 and look.
I believe this experiment had been performed already. Stephen,
isn't that the case?
next prev parent reply other threads:[~2005-02-12 19:41 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-11 21:55 2.6.10 TCP troubles -- suggested patch Hubert Tonneau
2005-02-11 22:54 ` Rick Jones
2005-02-11 23:09 ` Nivedita Singhvi
2005-02-11 23:40 ` Rick Jones
2005-02-12 1:08 ` David S. Miller
2005-02-12 1:09 ` David S. Miller
2005-02-12 14:31 ` Alexey Kuznetsov
2005-02-12 19:28 ` David S. Miller
2005-02-12 19:44 ` Leonid Grossman
2005-02-12 19:52 ` Alexey Kuznetsov
2005-02-15 23:25 ` David S. Miller
2005-02-12 20:19 ` rick jones
2005-02-12 20:28 ` David S. Miller
2005-02-12 20:56 ` Alexey Kuznetsov
2005-02-12 21:27 ` Nivedita Singhvi
2005-02-12 21:43 ` rick jones
2005-02-12 22:00 ` Alexey Kuznetsov
2005-02-13 1:29 ` rick jones
2005-02-11 23:04 ` Stephen Hemminger
2005-02-12 1:07 ` David S. Miller
2005-02-12 12:11 ` Andi Kleen
2005-02-12 19:23 ` David S. Miller
2005-02-12 21:30 ` Andi Kleen
2005-02-12 14:16 ` Alexey Kuznetsov
2005-02-12 19:41 ` David S. Miller [this message]
2005-02-12 20:03 ` Alexey Kuznetsov
2005-02-15 23:26 ` David S. Miller
2005-02-15 23:42 ` Rick Jones
2005-02-15 23:23 ` David S. Miller
2005-02-16 9:13 ` Alexey Kuznetsov
2005-02-16 17:50 ` David S. Miller
-- strict thread matches above, loose matches on Subject: below --
2005-02-20 23:06 Hubert Tonneau
2005-02-16 20:00 Hubert Tonneau
2005-02-13 10:52 Hubert Tonneau
2005-02-14 14:12 ` Alexey Kuznetsov
2005-02-10 21:53 Hubert Tonneau
2005-02-10 22:36 ` Rick Jones
2005-02-11 1:16 ` David S. Miller
[not found] <050QTJA12@server5.heliogroup.fr>
2005-02-09 18:59 ` Stephen Hemminger
2005-02-09 20:25 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050212114132.5f7b7ffe.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hubert.tonneau@fullpliant.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@oss.sgi.com \
--cc=niv@us.ibm.com \
--cc=rick.jones2@hp.com \
--cc=romieu@fr.zoreil.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).