From: Jon Mason <jdmason@us.ibm.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, akpm@osdl.org, netdev@oss.sgi.com
Subject: Re: [patch 2.6.11-rc3 5/5] r8169: synchronization and balancing when the device is closed
Date: Mon, 14 Feb 2005 11:16:54 -0600 [thread overview]
Message-ID: <200502141116.54441.jdmason@us.ibm.com> (raw)
In-Reply-To: <20050211234522.GD13644@electric-eye.fr.zoreil.com>
[...]
> @@ -2399,6 +2398,8 @@ static int rtl8169_close(struct net_devi
>
> free_irq(dev->irq, dev);
>
> + netif_poll_enable(dev);
> +
> pci_free_consistent(pdev, R8169_RX_RING_BYTES, tp->RxDescArray,
> tp->RxPhyAddr);
> pci_free_consistent(pdev, R8169_TX_RING_BYTES, tp->TxDescArray,
>
> _
Dumb question....Why is this needed? dev_close has already checked for the
bit before it calls the rtl8169_close routine (and it was already ripped out
by netif_poll_disable in rtl8169_down).
--
Jon Mason
jdmason@us.ibm.com
next prev parent reply other threads:[~2005-02-14 17:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-11 23:39 [patch 2.6.11-rc3 1/5] r8169: endianness fixes Francois Romieu
2005-02-11 23:41 ` [patch 2.6.11-rc3 2/5] r8169: merge of Realtek's code Francois Romieu
2005-02-11 23:42 ` [patch 2.6.11-rc3 3/5] r8169: typo in debugging code Francois Romieu
2005-02-11 23:44 ` [patch 2.6.11-rc3 4/5] r8169: screaming irq when the device is closed Francois Romieu
2005-02-11 23:45 ` [patch 2.6.11-rc3 5/5] r8169: synchronization and balancing " Francois Romieu
2005-02-14 17:16 ` Jon Mason [this message]
2005-02-14 19:31 ` Francois Romieu
2005-02-13 17:49 ` [patch 2.6.11-rc3 1/5] r8169: endianness fixes Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200502141116.54441.jdmason@us.ibm.com \
--to=jdmason@us.ibm.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).