From: Chris Wright <chrisw@osdl.org>
To: Pablo Neira <pablo@eurodev.net>
Cc: Chris Wright <chrisw@osdl.org>,
netdev@oss.sgi.com, davem@davemloft.net, jmorris@redhat.com,
sds@epoch.ncsc.mil, serue@us.ibm.com
Subject: Re: [RFC][PATCH 2/3] netlink check sender, audit
Date: Mon, 14 Feb 2005 19:47:08 -0800 [thread overview]
Message-ID: <20050215034708.GG27645@shell0.pdx.osdl.net> (raw)
In-Reply-To: <42115E7E.6050909@eurodev.net>
* Pablo Neira (pablo@eurodev.net) wrote:
> Thanks for the explanation. I don't still like so much the new
> netlink_kernel_create_check function. I think that we could get more
> variations of netlink_kernel_create in future just to add another
> feature/checking. So I prefer new function (netlink_kernel_set_check)
I agree, had the same concern. I breifly considered an ops struct that
could be passed in during registration so that it could grow a little
easier.
> that set check_sender if it's needed once the netlink socket is created.
> I've modified your patches to use this function.
Great, thanks. This is technically racy. It's possible (albeit small
window) that something could be delivered before this is set. Using a
callback struct during registration would fix this.
thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
next prev parent reply other threads:[~2005-02-15 3:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-12 9:01 [RFC][PATCH 0/3] netlink check sender Chris Wright
2005-02-12 9:02 ` [RFC][PATCH 1/3] " Chris Wright
2005-02-12 9:05 ` [RFC][PATCH 2/3] netlink check sender, audit Chris Wright
2005-02-12 9:06 ` [RFC][PATCH 3/3] netlink check sender, rtnetlink Chris Wright
2005-02-12 16:48 ` [RFC][PATCH 2/3] netlink check sender, audit Pablo Neira
2005-02-12 21:41 ` Pablo Neira
2005-02-14 13:08 ` Stephen Smalley
2005-02-15 0:13 ` Chris Wright
2005-02-15 2:29 ` Pablo Neira
2005-02-15 2:36 ` Pablo Neira
2005-02-15 3:47 ` Chris Wright [this message]
2005-02-15 22:19 ` Pablo Neira
2005-02-15 22:22 ` Chris Wright
2005-02-15 22:27 ` Pablo Neira
2005-02-16 0:11 ` Chris Wright
2005-02-16 3:42 ` James Morris
2005-02-15 0:11 ` Chris Wright
2005-02-14 12:59 ` [RFC][PATCH 1/3] netlink check sender Stephen Smalley
2005-02-14 13:05 ` Stephen Smalley
2005-02-15 0:22 ` Chris Wright
2005-02-15 0:17 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050215034708.GG27645@shell0.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=davem@davemloft.net \
--cc=jmorris@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=pablo@eurodev.net \
--cc=sds@epoch.ncsc.mil \
--cc=serue@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).