netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Cc: torvalds@osdl.org, davem@davemloft.net, netdev@oss.sgi.com,
	yoshfuji@linux-ipv6.org
Subject: Re: [IPV4] Fix ip_rt_gc_min_interval_ms procfs/sysctl
Date: Fri, 18 Feb 2005 02:49:17 -0800	[thread overview]
Message-ID: <20050218024917.2e5c19ec.akpm@osdl.org> (raw)
In-Reply-To: <20050218.192430.98634850.yoshfuji@linux-ipv6.org>

YOSHIFUJI Hideaki / ____________ <yoshfuji@linux-ipv6.org> wrote:
>
> Recently, we added gc_min_interval_ms procfs/sysctl.
> 
>  Because type of ip_rt_gc_min_interval is int, 
>  use of ulong helpers is inappropriate and unsafe.
>  I believe it breaks some archs that the size of unsigned long
>  is not equal to one of int.
> 
>  So, let's add new sysctl helpers and use them instead.
>  This also fixes inconsistency between procfs and sysctl.

I disagree.  ip_rt_gc_min_interval is an `int' and does not need to be
changed to `long' - note how is is always used as a time delta.

So the current code works OK.  However it is rather poor design, because it
exposes the value of jiffies to userspace.  So the user and his scripts
need to know what the machine's current HZ value is to set this tunable
sanely.

A better approach wold be to rework ip_rt_gc_min_interval so that its
userspace-visible units are milliseconds.

  reply	other threads:[~2005-02-18 10:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-18 10:24 [IPV4] Fix ip_rt_gc_min_interval_ms procfs/sysctl YOSHIFUJI Hideaki / 吉藤英明
2005-02-18 10:49 ` Andrew Morton [this message]
2005-02-18 10:59   ` YOSHIFUJI Hideaki / 吉藤英明
2005-02-18 11:02   ` Andrew Morton
2005-02-18 11:09     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050218024917.2e5c19ec.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=davem@davemloft.net \
    --cc=netdev@oss.sgi.com \
    --cc=torvalds@osdl.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).