From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: Intel and TOE in the news Date: 22 Feb 2005 22:43:45 +0100 Message-ID: <20050222214345.GA51890@muc.de> References: <20050222180711.GA84438@muc.de> <200502222052.j1MKqaDD022407@guinness.s2io.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "'Stephen Hemminger'" , hadi@cyberus.ca, "'rick jones'" , netdev@oss.sgi.com, "'Alex Aizman'" Date: Tue, 22 Feb 2005 22:43:45 +0100 To: Leonid Grossman Content-Disposition: inline In-Reply-To: <200502222052.j1MKqaDD022407@guinness.s2io.com> Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org > TSO case is probably different - TSO hardware just sets PSH on the last > fragment only (and only if the flag was set on the original large tx > packet). Receiver doesn't really know if the sender is TSO-capable or not > and will ACK the same way - will it not? > Anyway, with LRO we do change rx packet count so affecting parts of TCP that > depend on packet count is indeed a concern; I guess we'll find out soon > enough whether there are real issues with the approach :-) Linux doesn't depend on packet count; it keeps an estimate called rcv_mss about the biggest seen packet size and acks every 2*rcv_mss worth of data. Your scheme would likely result in acking every two of your large packets as soon as the connection is out of "quickack" mode. So there would be on wire differences. > > Linux TCP RX path didn't care about PSH last time I checked. Actually it does for measuring the rcv_mss for very small MTUs. Shouldn't matter in practice though. -Andi