From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
To: "David S. Miller" <davem@davemloft.net>
Cc: Stephen Hemminger <shemminger@osdl.org>,
mostrows@speakeasy.net, kuznet@ms2.inr.ac.ru, netdev@oss.sgi.com
Subject: Re: pppoe and receive checksum offload
Date: Mon, 28 Feb 2005 12:21:30 +0300 [thread overview]
Message-ID: <20050228092130.GA26076@yakov.inr.ac.ru> (raw)
In-Reply-To: <20050227202011.5ccefb22.davem@davemloft.net>
Hello!
> Changing or expanding the link level headers should only mess
> up the hw checksum if you are using CHECKSUM_HW, is that what
> your skge driver is using?
Well, even if this driver uses CHECKSUM_UNNECESSARY, the bug is still
apparently present for another devices which use CHECKSUM_HW.
Actually, the bug is in ppp_input(). It is responsible for setting correct
ip_summed before doing netif_rx(). It could even optimize subtracting
checksum of stripped ppp header from ip_summed (f.e. ipgre_rcv() do this)
But suggested fix is still correct. Unless there are another users of
ppp_input() with the same problem.
Alexey
next prev parent reply other threads:[~2005-02-28 9:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-24 23:59 pppoe and receive checksum offload Stephen Hemminger
2005-02-28 4:20 ` David S. Miller
2005-02-28 9:21 ` Alexey Kuznetsov [this message]
2005-02-28 17:12 ` Stephen Hemminger
2005-02-28 23:32 ` David S. Miller
2005-03-01 0:01 ` shemminger
2005-02-28 11:31 ` Herbert Xu
2005-02-28 11:39 ` Herbert Xu
2005-02-28 14:04 ` Alexey Kuznetsov
2005-03-01 1:04 ` Herbert Xu
2005-03-10 5:13 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050228092130.GA26076@yakov.inr.ac.ru \
--to=kuznet@ms2.inr.ac.ru \
--cc=davem@davemloft.net \
--cc=mostrows@speakeasy.net \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).