From: Christoph Hellwig <hch@infradead.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: "Randy.Dunlap" <randy.dunlap@verizon.net>,
netdev@oss.sgi.com, torvalds <torvalds@osdl.org>,
akpm <akpm@osdl.org>
Subject: Re: [PATCH] tulip: de2104x, fix init. sections
Date: Wed, 2 Mar 2005 07:25:10 +0000 [thread overview]
Message-ID: <20050302072510.GA12464@infradead.org> (raw)
In-Reply-To: <422558B2.6020105@pobox.com>
On Wed, Mar 02, 2005 at 01:09:54AM -0500, Jeff Garzik wrote:
> Randy.Dunlap wrote:
> >tulip/de2104x: some __devinit functions were calling __init
> > functions, made the latter __devinit also;
>
> Should go the other way: all the stuff in de2104x should be __init, not
> __devinit.
>
> Nobody ever hotplugs a de2104x.
How comes that you want to dictate what cards I put into my hotplug
PCI slots?
next prev parent reply other threads:[~2005-03-02 7:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-02 5:44 [PATCH] tulip: de2104x, fix init. sections Randy.Dunlap
2005-03-02 6:09 ` Jeff Garzik
2005-03-02 7:02 ` Linus Torvalds
2005-03-02 7:03 ` Jeff Garzik
2005-03-02 7:14 ` Linus Torvalds
2005-03-02 7:25 ` Christoph Hellwig [this message]
2005-03-02 7:30 ` Jeff Garzik
2005-03-02 7:32 ` Christoph Hellwig
2005-03-02 7:37 ` Jeff Garzik
2005-03-02 7:41 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050302072510.GA12464@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=randy.dunlap@verizon.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).