From: Ralf Baechle <ralf@linux-mips.org>
To: netdev@oss.sgi.com
Subject: [PATCH] Fix ROSE security hole
Date: Wed, 2 Mar 2005 09:06:58 +0000 [thread overview]
Message-ID: <20050302090658.GA6873@linux-mips.org> (raw)
ROSE wasn't verifying the ndigis argument of a new route resulting in a
minor security hole.
Index: bk-afu/net/rose/rose_route.c
===================================================================
--- bk-afu.orig/net/rose/rose_route.c 2005-02-05 22:16:25.582983368 +0000
+++ bk-afu/net/rose/rose_route.c 2005-02-05 22:16:25.585982912 +0000
@@ -727,7 +727,8 @@
}
if (rose_route.mask > 10) /* Mask can't be more than 10 digits */
return -EINVAL;
-
+ if (rose_route.ndigis > 8) /* No more than 8 digipeats */
+ return -EINVAL;
err = rose_add_node(&rose_route, dev);
dev_put(dev);
return err;
next reply other threads:[~2005-03-02 9:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-02 9:06 Ralf Baechle [this message]
2005-03-11 3:47 ` [PATCH] Fix ROSE security hole David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050302090658.GA6873@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).