netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: bunk@stusta.de, netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects
Date: Wed, 2 Mar 2005 12:38:29 -0800	[thread overview]
Message-ID: <20050302123829.51dbc44b.akpm@osdl.org> (raw)
In-Reply-To: <42261004.4000501@pobox.com>

Jeff Garzik <jgarzik@pobox.com> wrote:
>
> Adrian Bunk wrote:
> > On Wed, Mar 02, 2005 at 01:43:04AM -0500, Jeff Garzik wrote:
> > 
> >>Adrian Bunk wrote:
> >>
> >>>+	select CRYPTO
> >>>	select CRYPTO_AES
> >>>	---help---
> >>>	Include software based cipher suites in support of IEEE 802.11i 
> >>>	(aka TGi, WPA, WPA2, WPA-PSK, etc.) for use with CCMP enabled 
> >>>	networks.
> >>>@@ -54,10 +55,11 @@
> >>>	"ieee80211_crypt_ccmp".
> >>>
> >>>config IEEE80211_CRYPT_TKIP
> >>>	tristate "IEEE 802.11i TKIP encryption"
> >>>	depends on IEEE80211
> >>>+	select CRYPTO
> >>>	select CRYPTO_MICHAEL_MIC
> >>
> >>
> >>'select CRYPTO_AES' should 'select CRYPTO' automatically, I would hope.
> > 
> > 
> > This would result in a recursive dependency.
> 
> No, it wouldn't.  CRYPTO_AES depends on CRYPTO, which depends on nothing.
> 

Thing is, CRYPTO_AES on only selectable on x86.

So really, IEEE80211_CRYPT_CCMP should depend upon CRYPTO_AES rather than
selecting it.  But that confuses users.

  reply	other threads:[~2005-03-02 20:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20050223014233.6710fd73.akpm@osdl.org>
2005-02-26 11:31 ` [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects Adrian Bunk
2005-03-02  6:43   ` Jeff Garzik
2005-03-02 14:08     ` Adrian Bunk
2005-03-02 19:12       ` Jeff Garzik
2005-03-02 20:38         ` Andrew Morton [this message]
2005-03-02 21:07           ` Jeff Garzik
2005-03-02 21:18             ` Andrew Morton
2005-03-02 21:56               ` Adrian Bunk
2005-03-02 22:14                 ` Andrew Morton
2005-03-02 22:41               ` Jeff Garzik
2005-03-02 22:45                 ` Adrian Bunk
2005-03-02 22:49                   ` Jeff Garzik
2005-03-03 15:07                     ` How to handle the multiple aes variants on i386? Adrian Bunk
2005-03-02 21:59         ` [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050302123829.51dbc44b.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).