From: Andrew Morton <akpm@osdl.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: bunk@stusta.de, netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects
Date: Wed, 2 Mar 2005 13:18:17 -0800 [thread overview]
Message-ID: <20050302131817.2e61805f.akpm@osdl.org> (raw)
In-Reply-To: <42262B08.2040401@pobox.com>
Jeff Garzik <jgarzik@pobox.com> wrote:
>
> > Thing is, CRYPTO_AES on only selectable on x86.
>
> You're thinking about CRYPTO_AES_586. But looking at crypto/Kconfig,
> the dependencies are a bit weird:
>
> config CRYPTO_AES
> tristate "AES cipher algorithms"
> depends on CRYPTO && !(X86 && !X86_64)
> config CRYPTO_AES_586
> tristate "AES cipher algorithms (i586)"
> depends on CRYPTO && (X86 && !X86_64)
That's pretty broken, isn't it?
Would be better to just do:
config CRYPTO_AES
select CRYPTO_AES_586 if (X86 && !X86_64)
select CRYPTO_AES_OTHER if !(X86 && !X86_64)
and hide CRYPTO_AES_586 and CRYPTO_AES_OTHER from the outside world.
next prev parent reply other threads:[~2005-03-02 21:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050223014233.6710fd73.akpm@osdl.org>
2005-02-26 11:31 ` [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects Adrian Bunk
2005-03-02 6:43 ` Jeff Garzik
2005-03-02 14:08 ` Adrian Bunk
2005-03-02 19:12 ` Jeff Garzik
2005-03-02 20:38 ` Andrew Morton
2005-03-02 21:07 ` Jeff Garzik
2005-03-02 21:18 ` Andrew Morton [this message]
2005-03-02 21:56 ` Adrian Bunk
2005-03-02 22:14 ` Andrew Morton
2005-03-02 22:41 ` Jeff Garzik
2005-03-02 22:45 ` Adrian Bunk
2005-03-02 22:49 ` Jeff Garzik
2005-03-03 15:07 ` How to handle the multiple aes variants on i386? Adrian Bunk
2005-03-02 21:59 ` [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050302131817.2e61805f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).