From: Christoph Hellwig <hch@infradead.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Stephen Hemminger <shemminger@osdl.org>, netdev@oss.sgi.com
Subject: Re: [PATCH] (3/12) skge: remove unneeded include's
Date: Thu, 3 Mar 2005 21:51:16 +0000 [thread overview]
Message-ID: <20050303215116.GA16132@infradead.org> (raw)
In-Reply-To: <42278470.2070807@pobox.com>
On Thu, Mar 03, 2005 at 04:41:04PM -0500, Jeff Garzik wrote:
> Stephen Hemminger wrote:
> >Get rid of unnecessary include's
> >
> >Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
> >
> >--- skge-2.6.11/drivers/net/skge.c.orig 2005-03-02
> >17:15:44.000000000 -0800
> >+++ skge-2.6.11/drivers/net/skge.c 2005-03-02 17:17:25.000000000 -0800
> >@@ -30,13 +30,10 @@
> > #include <linux/moduleparam.h>
> > #include <linux/netdevice.h>
> > #include <linux/etherdevice.h>
> >-#include <linux/dma-mapping.h>
>
> Why is this one is unnecessary?
Becasue the driver is using the pci_ variants of the dma mapping routines,
which are in pci.h
prev parent reply other threads:[~2005-03-03 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-03 19:34 [PATCH] (3/12) skge: remove unneeded include's Stephen Hemminger
2005-03-03 21:41 ` Jeff Garzik
2005-03-03 21:51 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050303215116.GA16132@infradead.org \
--to=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).