From: Thomas Graf <tgraf@suug.ch>
To: jamal <hadi@cyberus.ca>
Cc: Stephen Hemminger <shemminger@osdl.org>, netdev@oss.sgi.com
Subject: Re: [PATCH] iproute2 updates
Date: Fri, 4 Mar 2005 14:26:53 +0100 [thread overview]
Message-ID: <20050304132653.GF31837@postel.suug.ch> (raw)
In-Reply-To: <1109908154.1091.486.camel@jzny.localdomain>
* jamal <1109908154.1091.486.camel@jzny.localdomain> 2005-03-03 22:49
> On Thu, 2005-03-03 at 21:35, Thomas Graf wrote:
> > Stephen,
> >
> > You may pull the following changes from bk://tgr.bkbits.net/iproute2-tgr-fix
>
> Other than NPROBES change, shouldnt the other changes be reflective of
> whats in the kernel? This is the cost of keeping private headers. My
> suggestions would be to let Steve on every major release to just sync
> the header files.
Well, these are not exact copies, all the __KERNEL__ stuff is missing, a
few CONFIG ifdefs must be cut out and a few extra bits such as u32 mark
structures. I updated them because some of the structures were outdated.
I do not care how it is done but it required an update.
> PS:- Also on you 1/2 changes - I notice one bug fix, the rest seems
> cosmetic - what does that buy you? Does it make the code more readable
> etc?
Yes, it improves readability a lot, I first thought the neighbour code
had a bug until I read the code bit by bit from the top and there was
quite some logic in it that one wouldn't expect such as parallel code
paths for errors and normal execution. I replacted the rta_len checks
with RTA_PAYLOAD and adapted the logic to be like the rest of the
rtnetlink handle code.
next prev parent reply other threads:[~2005-03-04 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-04 2:35 [PATCH] iproute2 updates Thomas Graf
2005-03-04 3:49 ` jamal
2005-03-04 13:26 ` Thomas Graf [this message]
2005-03-04 16:42 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050304132653.GF31837@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=hadi@cyberus.ca \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).