From: Francois Romieu <romieu@fr.zoreil.com>
To: Jon Mason <jdmason@us.ibm.com>
Cc: Stephen Hemminger <shemminger@osdl.org>, netdev@oss.sgi.com
Subject: Re: r8169: panic on 2.6.11
Date: Sat, 5 Mar 2005 00:58:04 +0100 [thread overview]
Message-ID: <20050304235804.GD1148@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <200503041728.54026.jdmason@us.ibm.com>
Jon Mason <jdmason@us.ibm.com> :
[...]
> > @@ -2210,6 +2211,24 @@ rtl8169_rx_interrupt(struct net_device *
> > pci_action(tp->pci_dev, le64_to_cpu(desc->addr),
> > tp->rx_buf_sz, PCI_DMA_FROMDEVICE);
> >
> > + if (pkt_size >= tp->rx_buf_sz) {
> > + show_size = 1;
> > + pkt_size = tp->rx_buf_sz;
> > + }
>
> Shouldn't the above be dev->mtu (instead of tp->rx_buf_sz), otherwise there
> won't be enough room for ethernet header, CRC, etc.
There is no room left in the buffer. I want it to be translated into the
biggest skb_put() possible. tp->rx_buf_sz already account the headers (see
rtl8169_set_rxbufsize), no ?
At worst it is possible we are a bit pessimistic imho.
--
Ueimor
next prev parent reply other threads:[~2005-03-04 23:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-04 21:28 r8169: panic on 2.6.11 Stephen Hemminger
2005-03-04 21:37 ` Jeff Garzik
2005-03-04 21:50 ` Francois Romieu
[not found] ` <20050304135922.0b0a3911@dxpl.pdx.osdl.net>
[not found] ` <20050304221826.GA1028@electric-eye.fr.zoreil.com>
2005-03-04 22:53 ` Stephen Hemminger
2005-03-04 23:02 ` Francois Romieu
2005-03-04 23:28 ` Jon Mason
2005-03-04 23:49 ` Stephen Hemminger
2005-03-05 0:37 ` Francois Romieu
2005-03-05 5:03 ` Jon Mason
2005-03-05 6:34 ` Stephen Hemminger
2005-03-07 18:59 ` Stephen Hemminger
2005-03-04 23:58 ` Francois Romieu [this message]
2005-03-04 21:39 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050304235804.GD1148@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=jdmason@us.ibm.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).